This is an archive of the discontinued LLVM Phabricator instance.

Differential D112148

Install future to run mypy on Python 3
ClosedPublic

Authored by thopre on Oct 20 2021, 9:13 AM.

Details

Reviewers
cmatthews
tnfchris
kpdev42
Commits
rLNTefe393557fb7: Install future to run mypy on Python 3
Summary

LNT uses future which does not come in standard in recent Python 3
versions, leading to mypy failing in Python 3 mode. Adding an explicit
dependency on future solves the problem.

Diff Detail

Event Timeline

thopre requested review of this revision.Oct 20 2021, 9:13 AM
thopre created this revision.
Harbormaster completed remote builds in B129753: Diff 380986.Oct 20 2021, 9:13 AM
thopre mentioned this in D110839: [LNT] Added reading nm and objdump paths from env variables.Oct 20 2021, 9:14 AM
tnfchris accepted this revision.Oct 20 2021, 9:46 AM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 20 2021, 9:46 AM
Closed by commit rLNTefe393557fb7: Install future to run mypy on Python 3 (authored by thopre). · Explain WhyOct 20 2021, 10:34 AM
This revision was automatically updated to reflect the committed changes.
thopre added a commit: rLNTefe393557fb7: Install future to run mypy on Python 3.

Revision Contents

PathSize
1 line

Diff 380986

tox.ini

Show All 13 Linescommands =
lit -sv ./tests/ lit -sv ./tests/
[testenv:mypy] [testenv:mypy]
basepython = python3 basepython = python3
skip_install = true skip_install = true
deps = deps =
mypy >= 0.910 mypy >= 0.910
sqlalchemy-stubs sqlalchemy-stubs
future
commands = commands =
# No where close to passing yet, but nice to have. # No where close to passing yet, but nice to have.
- mypy --install-types --non-interactive --junit-xml=junit-{envname}.xml --py2 --ignore-missing-imports lnt - mypy --install-types --non-interactive --junit-xml=junit-{envname}.xml --py2 --ignore-missing-imports lnt
- mypy --install-types --non-interactive --junit-xml=junit-{envname}.xml --ignore-missing-imports lnt - mypy --install-types --non-interactive --junit-xml=junit-{envname}.xml --ignore-missing-imports lnt
[testenv:flake8] [testenv:flake8]
skip_install = true skip_install = true
deps = deps =
Show All 15 Lines