This is an archive of the discontinued LLVM Phabricator instance.

[LV] Pre-commit test for D111846
ClosedPublic

Authored by dcaballe on Oct 18 2021, 10:52 PM.

Diff Detail

Event Timeline

dcaballe requested review of this revision.Oct 18 2021, 10:52 PM
dcaballe created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2021, 10:52 PM
fhahn accepted this revision.Oct 19 2021, 8:33 AM

LGTM, thanks!

llvm/test/Transforms/LoopVectorize/X86/pr52111.ll
119 ↗(On Diff #380588)

!noalias should not be needed, as %input already has noalias.

125 ↗(On Diff #380588)

alias.scope should not be added as %input is noalias.

136 ↗(On Diff #380588)

Only this seems to be needed, the other metadata can be dropped.

This revision is now accepted and ready to land.Oct 19 2021, 8:33 AM
dcaballe marked 3 inline comments as done.Oct 19 2021, 6:09 PM

Thanks, true! I'll address those before committing.

dcaballe updated this revision to Diff 381126.Oct 20 2021, 6:42 PM
  • Renamed filed
  • Added a new test
  • Regenerated the check rules with utility
dcaballe updated this revision to Diff 383686.Oct 31 2021, 2:54 PM
  • Added test for poison phi
  • Added tests to make sure we don't drop poison-generating flags from instructions not contributing to address computation of masked loads/stores.
  • Improved comments
dcaballe updated this revision to Diff 385338.Nov 7 2021, 6:29 AM

Added test for non-predicated poison-generation instructions that
contribute to the address computation of a widen masked load

dcaballe updated this revision to Diff 385891.Nov 9 2021, 10:44 AM

Added new test. Thanks, Florian!

This revision was automatically updated to reflect the committed changes.