This is an archive of the discontinued LLVM Phabricator instance.

[runtimes] Make sure LLVM_LIT_ARGS is set before including individual runtimes
ClosedPublic

Authored by ldionne on Oct 18 2021, 2:57 PM.

Details

Summary

Otherwise, the individual check-cxx, check-cxxabi and similar targets
will not know about LLVM_LIT_ARGS, and we'll end up running lit without
any argument.

Diff Detail

Event Timeline

ldionne created this revision.Oct 18 2021, 2:57 PM
ldionne requested review of this revision.Oct 18 2021, 2:57 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 18 2021, 2:57 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
phosek accepted this revision.Oct 18 2021, 6:13 PM

LGTM

mstorsjo accepted this revision.Oct 18 2021, 10:42 PM

LGTM, but that's odd, I'm fairly sure that I tested that this actually had effect when I added it. But maybe I didn't?

ldionne accepted this revision as: Restricted Project.Oct 19 2021, 5:21 AM
This revision is now accepted and ready to land.Oct 19 2021, 5:21 AM