[LLD][TEST] Add a test case for negative addends for R_X86_64_PC32 relocations

[gbreynoo]

Summary

This test is derived from a test case we have locally but I could not see an equivalent in LLD's testing.

[MaskRay]

You may rename x86-64-reloc-32-fpic.s as appropriate and add the new test there, too.

[gbreynoo]

As suggested by Maskray I have renamed x86-64-reloc-32-fpic.s and added a R_X86_64_32 equivalent of the test. To be consistent x86-64-reloc-pc32-fpic.s was also renamed and the new test case added.
Note that git doesn't appear to detect the renames, it may be best for me to commit the code change and rename separately?

[MaskRay]

In D111803#3066817, @gbreynoo wrote:

As suggested by Maskray I have renamed x86-64-reloc-32-fpic.s and added a R_X86_64_32 equivalent of the test. To be consistent x86-64-reloc-pc32-fpic.s was also renamed and the new test case added.
Note that git doesn't appear to detect the renames, it may be best for me to commit the code change and rename separately?

I think that's unnecessary. We already need to look at deleted commits if archaeology on the whole history is needed in the future (likely no for this case).

lld/test/ELF/x86-64-reloc-32-fpic.s

-# REQUIRES: x86
-# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
-# RUN: not ld.lld -shared %t.o -o /dev/null 2>&1 | FileCheck %s
-
-# CHECK: relocation R_X86_64_32 cannot be used against symbol _shared; recompile with -fPIC
-# CHECK: >>> defined in {{.*}}
-# CHECK: >>> referenced by {{.*}}:(.data+0x0)
-
-.data
-.long _shared

lld/test/ELF/x86-64-reloc-32.s

+# REQUIRES: x86
+# RUN: rm -rf %t && split-file %s %t
+
+## Check recompile with -fPIC error message
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %t/shared.s -o %t/shared.o
+# RUN: not ld.lld -shared %t/shared.o -o /dev/null 2>&1 | FileCheck %s
+
+# CHECK: relocation R_X86_64_32 cannot be used against symbol _shared; recompile with -fPIC
+# CHECK: >>> defined in {{.*}}
+# CHECK: >>> referenced by {{.*}}:(.data+0x0)
+
+## Check patching of negative addends
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/addend.s -o %t/addend.o
+# RUN: not ld.lld --section-start=.text=0x0 %t/addend.o -o /dev/null 2>&1 | FileCheck %s --check-prefix RANGE
+
+# RANGE: relocation R_X86_64_32 out of range
+
+#--- shared.s
+.data
+.long _shared
+
+#--- addend.s
+.text
+.globl _start
+_start:
+    .reloc ., R_X86_64_32, .text-1
+    .space 4

lld/test/ELF/x86-64-reloc-pc32-fpic.s

-# REQUIRES: x86
-# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
-# RUN: not ld.lld -shared %t.o -o /dev/null 2>&1 | FileCheck %s
-
-# CHECK: relocation R_X86_64_PC32 cannot be used against symbol _shared; recompile with -fPIC
-# CHECK: >>> defined in {{.*}}
-# CHECK: >>> referenced by {{.*}}:(.data+0x1)
-
-.data
- .byte 0xe8
- .long _shared - .

lld/test/ELF/x86-64-reloc-pc32.s

+# REQUIRES: x86
+# RUN: rm -rf %t && split-file %s %t
+
+## Check recompile with -fPIC error message
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %t/shared.s -o %t/shared.o
+# RUN: not ld.lld -shared %t/shared.o -o /dev/null 2>&1 | FileCheck %s
+
+# CHECK: relocation R_X86_64_PC32 cannot be used against symbol _shared; recompile with -fPIC
+# CHECK: >>> defined in {{.*}}
+# CHECK: >>> referenced by {{.*}}:(.data+0x1)
+
+## Check patching of negative addends
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64 -defsym ADDEND=1 %t/addend.s -o %t/1.o
+# RUN: llvm-mc -filetype=obj -triple=x86_64 -defsym ADDEND=2147483648 %t/addend.s -o %t/2.o
+# RUN: llvm-mc -filetype=obj -triple=x86_64 -defsym ADDEND=2147483649 %t/addend.s -o %t/3.o
+
+# RUN: ld.lld --section-start=.text=0x0 %t/1.o -o %t/1out
+# RUN: ld.lld --section-start=.text=0x0 %t/2.o -o %t/2out
+# RUN: not ld.lld --section-start=.text=0x0 %t/3.o -o /dev/null 2>&1 | FileCheck %s --check-prefix RANGE
+
+# RANGE: relocation R_X86_64_PC32 out of range
+
+# RUN: llvm-readelf --hex-dump=.text %t/1out | FileCheck %s -DADDEND=ffffffff --check-prefix DUMP
+# RUN: llvm-readelf --hex-dump=.text %t/2out | FileCheck %s -DADDEND=00000080 --check-prefix DUMP
+
+# DUMP:  0x00000000 [[ADDEND]]
+
+#--- shared.s
+.data
+ .byte 0xe8
+ .long _shared - .
+
+#--- addend.s
+.text
+.globl _start
+_start:
+    .reloc ., R_X86_64_PC32, .text-ADDEND
+    .space 4