This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Add a from-scratch config for running libunwind tests
ClosedPublic

Authored by ldionne on Oct 12 2021, 11:07 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Restricted Project
Commits
rG6fd55bba61bb: [libunwind] Add a from-scratch config for running libunwind tests
Summary

Running tests for libunwind is a lot simpler than running tests for
libc++, so a simple Lit config file is sufficient. The benefit is that
we disentangle the libunwind test configuration from the libc++ and
libc++abi test configuration. The setup was too complicated, which led
to some bugs (notably we were running against the system libunwind on
Apple platforms).

Diff Detail

Event Timeline

ldionne created this revision.Oct 12 2021, 11:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2021, 11:07 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested review of this revision.Oct 12 2021, 11:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2021, 11:07 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

I'll rebase D111290 top of this.

ldionne updated this revision to Diff 379192.Oct 12 2021, 2:41 PM

Fix typo in the config file that broke CI

I'll rebase D111290 top of this.

Awesome, thanks. Once this is in, I'll also have a PR to switch the default configuration to the from-scratch config -- we'll see if that one sticks.

ldionne updated this revision to Diff 379837.Oct 14 2021, 2:02 PM

Try to fix CI failures

phosek added a subscriber: phosek.Oct 14 2021, 11:43 PM
phosek added inline comments.
libunwind/test/configs/llvm-libunwind-shared.cfg.in
10

This is just a nit but libunwind is written in C++, but it doesn't use C++ standard library.

ldionne updated this revision to Diff 380378.Oct 18 2021, 6:57 AM
ldionne marked an inline comment as done.

Should fix issues on GCC.

libunwind/test/configs/llvm-libunwind-shared.cfg.in
10

Thanks!

ldionne updated this revision to Diff 380473.Oct 18 2021, 10:49 AM

Hopefully resolve last issues

ldionne updated this revision to Diff 380659.Oct 19 2021, 5:25 AM

Try to fix the Apple backdeployment tests

ldionne updated this revision to Diff 380673.Oct 19 2021, 6:27 AM

Investigate backdeployment tests

ldionne updated this revision to Diff 380703.Oct 19 2021, 8:36 AM

Disable the test -- I want to land this before investigating

ldionne updated this revision to Diff 380705.Oct 19 2021, 9:03 AM

All CI issues should be resolved

ldionne accepted this revision.Oct 19 2021, 9:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 19 2021, 9:04 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.