Running tests for libunwind is a lot simpler than running tests for
libc++, so a simple Lit config file is sufficient. The benefit is that
we disentangle the libunwind test configuration from the libc++ and
libc++abi test configuration. The setup was too complicated, which led
to some bugs (notably we were running against the system libunwind on
Apple platforms).
Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project Restricted Project - Commits
- rG6fd55bba61bb: [libunwind] Add a from-scratch config for running libunwind tests
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Awesome, thanks. Once this is in, I'll also have a PR to switch the default configuration to the from-scratch config -- we'll see if that one sticks.
libunwind/test/configs/llvm-libunwind-shared.cfg.in | ||
---|---|---|
10 | This is just a nit but libunwind is written in C++, but it doesn't use C++ standard library. |
Comment Actions
Should fix issues on GCC.
libunwind/test/configs/llvm-libunwind-shared.cfg.in | ||
---|---|---|
10 | Thanks! |
This is just a nit but libunwind is written in C++, but it doesn't use C++ standard library.