[DebugInfo] retainedTypes should not have subprograms

[ellis]

Summary

After D80369, the retainedTypes in CU's should not have any
subprograms so we should not handle that case when emitting debug info.

[ellis]

Fix tests

[ellis]

I found this while looking through the callsites to getOrCreateSubprogramDIE(). I was thinking of adding an assert to check that retainedTypes don't include SPs but it seems there are a lot of tests that do this.

[djtodoro]

This looks reasonable to me.

The call_site entries still point to the right subprograms after this patch, right?

[ellis]

In D111593#3060704, @djtodoro wrote:

This looks reasonable to me.

The call_site entries still point to the right subprograms after this patch, right?

Yep, just tested a basic program.

extern int foo();
int bar() { return foo() + 1; }

[djtodoro]

llvm/test/DebugInfo/MIR/AArch64/dbgcall-site-orr-moves.mir

75 ↗

(On Diff #378846)

retainedTypes: !3 - this should be removed completely, so we do not leave any ambiguity

78 ↗

(On Diff #378846)

and then remove this

[ellis]

Remove empty retainedTypes: from tests.

llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

DwarfDebug::getOrCreateDwarfCompileUnit(const DICompileUnit *DIUnit) {
   if (useSplitDwarf()) {
     NewCU.setSkeleton(constructSkeletonCU(NewCU));
     NewCU.setSection(Asm->getObjFileLowering().getDwarfInfoDWOSection());
   } else {
     finishUnitAttributes(DIUnit, NewCU);
     NewCU.setSection(Asm->getObjFileLowering().getDwarfInfoSection());
   }
 
-  // Create DIEs for function declarations used for call site debug info.
-  for (auto Scope : DIUnit->getRetainedTypes())
-    if (auto *SP = dyn_cast_or_null<DISubprogram>(Scope))
-      NewCU.getOrCreateSubprogramDIE(SP);
-
   CUMap.insert({DIUnit, &NewCU});
   CUDieMap.insert({&NewCU.getUnitDie(), &NewCU});
   return NewCU;
 }
 
 void DwarfDebug::constructAndAddImportedEntityDIE(DwarfCompileUnit &TheCU,
                                                   const DIImportedEntity *N) {
   if (isa<DILocalScope>(N->getScope()))