[flang][driver] Fix erroneous `&`

[awarzynski]

Summary

As pointed out by Valentin Clement in PR [1], we should be using &&
instead of &.

[1] https://github.com/flang-compiler/f18-llvm-project/pull/1113#discussion_r724321121

[MatsPetersson]

LGTM, trivial change!

[PeteSteinfeld]

Rather than continue with this patch, I would think that we'd just want to make an analogous change to https://reviews.llvm.org/D111308.

[awarzynski]

In D111395#3050964, @PeteSteinfeld wrote:

Rather than continue with this patch, I would think that we'd just want to make an analogous change to https://reviews.llvm.org/D111308.

This would mean making two unrelated changes in one patch. This patch updates PrescanAndSemaAction. This fix is not required in https://reviews.llvm.org/D111308, which implements a new frontend action base class, PrescanAndSemaDebugAction.

[PeteSteinfeld]

In D111395#3051044, @awarzynski wrote:

In D111395#3050964, @PeteSteinfeld wrote:

Rather than continue with this patch, I would think that we'd just want to make an analogous change to https://reviews.llvm.org/D111308.

This would mean making two unrelated changes in one patch. This patch updates PrescanAndSemaAction. This fix is not required in https://reviews.llvm.org/D111308, which implements a new frontend action base class, PrescanAndSemaDebugAction.

Sounds good. Go for it!

[awarzynski]

In D111395#3051073, @PeteSteinfeld wrote:

In D111395#3051044, @awarzynski wrote:

In D111395#3050964, @PeteSteinfeld wrote:

Rather than continue with this patch, I would think that we'd just want to make an analogous change to https://reviews.llvm.org/D111308.

This would mean making two unrelated changes in one patch. This patch updates PrescanAndSemaAction. This fix is not required in https://reviews.llvm.org/D111308, which implements a new frontend action base class, PrescanAndSemaDebugAction.

Sounds good. Go for it!

Thank you for reviewing! :)

flang/lib/Frontend/FrontendActions.cpp

 //===----------------------------------------------------------------------===//
 bool PrescanAction::BeginSourceFileAction() { return RunPrescan(); }
 
 bool PrescanAndParseAction::BeginSourceFileAction() {
   return RunPrescan() && RunParse();
 }
 
 bool PrescanAndSemaAction::BeginSourceFileAction() {
-  return RunPrescan() & RunParse() && RunSemanticChecks();
+  return RunPrescan() && RunParse() && RunSemanticChecks();
 }
 
 //===----------------------------------------------------------------------===//
 // Custom ExecuteAction
 //===----------------------------------------------------------------------===//
 void InputOutputTestAction::ExecuteAction() {
   CompilerInstance &ci = instance();