Page MenuHomePhabricator

[flang][driver] Fix erroneous `&`
ClosedPublic

Authored by awarzynski on Oct 8 2021, 2:51 AM.

Details

Summary

As pointed out by Valentin Clement in PR [1], we should be using &&
instead of &.

[1] https://github.com/flang-compiler/f18-llvm-project/pull/1113#discussion_r724321121

Diff Detail

Event Timeline

awarzynski created this revision.Oct 8 2021, 2:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2021, 2:51 AM
awarzynski requested review of this revision.Oct 8 2021, 2:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2021, 2:51 AM
MatsPetersson accepted this revision.Oct 8 2021, 2:59 AM

LGTM, trivial change!

This revision is now accepted and ready to land.Oct 8 2021, 2:59 AM
PeteSteinfeld requested changes to this revision.Oct 8 2021, 6:22 AM
PeteSteinfeld added a subscriber: PeteSteinfeld.

Rather than continue with this patch, I would think that we'd just want to make an analogous change to https://reviews.llvm.org/D111308.

This revision now requires changes to proceed.Oct 8 2021, 6:22 AM

Rather than continue with this patch, I would think that we'd just want to make an analogous change to https://reviews.llvm.org/D111308.

This would mean making two unrelated changes in one patch. This patch updates PrescanAndSemaAction. This fix is not required in https://reviews.llvm.org/D111308, which implements a new frontend action base class, PrescanAndSemaDebugAction.

PeteSteinfeld accepted this revision.Oct 8 2021, 7:26 AM

Rather than continue with this patch, I would think that we'd just want to make an analogous change to https://reviews.llvm.org/D111308.

This would mean making two unrelated changes in one patch. This patch updates PrescanAndSemaAction. This fix is not required in https://reviews.llvm.org/D111308, which implements a new frontend action base class, PrescanAndSemaDebugAction.

Sounds good. Go for it!

This revision is now accepted and ready to land.Oct 8 2021, 7:26 AM

Rather than continue with this patch, I would think that we'd just want to make an analogous change to https://reviews.llvm.org/D111308.

This would mean making two unrelated changes in one patch. This patch updates PrescanAndSemaAction. This fix is not required in https://reviews.llvm.org/D111308, which implements a new frontend action base class, PrescanAndSemaDebugAction.

Sounds good. Go for it!

Thank you for reviewing! :)

This revision was automatically updated to reflect the committed changes.