Page MenuHomePhabricator

[Driver][NetBSD] Use ToolChain reference instead of getToolChain().
ClosedPublic

Authored by fcambus on Oct 7 2021, 12:18 PM.

Diff Detail

Event Timeline

fcambus requested review of this revision.Oct 7 2021, 12:18 PM
fcambus created this revision.
Herald added a project: Restricted Project. · View Herald Transcript
mgorny added inline comments.Oct 7 2021, 12:36 PM
clang/lib/Driver/ToolChains/NetBSD.cpp
32–34

Since you're doing it for the other method, maybe it'd make sense to define ToolChain here as well.

fcambus updated this revision to Diff 378124.Oct 8 2021, 1:29 AM

Also define and use ToolChain reference in netbsd::Assembler::ConstructJob().

fcambus marked an inline comment as done.Oct 8 2021, 1:30 AM
fcambus added inline comments.
clang/lib/Driver/ToolChains/NetBSD.cpp
32–34

Makes sense, updated the diff.

mgorny accepted this revision.Oct 8 2021, 1:40 AM
This revision is now accepted and ready to land.Oct 8 2021, 1:40 AM
This revision was landed with ongoing or failed builds.Oct 8 2021, 2:14 AM
This revision was automatically updated to reflect the committed changes.
fcambus marked an inline comment as done.