Page MenuHomePhabricator

fcambus (Frederic Cambus)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 22 2021, 5:46 AM (108 w, 4 d)

Recent Activity

Sun, Mar 19

fcambus committed rG8510cf9fc1a4: [compiler-rt] Add missing #else clause to fix the build on NetBSD. (authored by fcambus).
[compiler-rt] Add missing #else clause to fix the build on NetBSD.
Sun, Mar 19, 1:47 AM · Restricted Project, Restricted Project
fcambus closed D146316: [compiler-rt] Add missing #else clause to fix the build on NetBSD..
Sun, Mar 19, 1:47 AM · Restricted Project, Restricted Project

Fri, Mar 17

fcambus requested review of D146316: [compiler-rt] Add missing #else clause to fix the build on NetBSD..
Fri, Mar 17, 11:07 AM · Restricted Project, Restricted Project

Thu, Mar 16

fcambus committed rG245f26a430aa: [docs] Document "PGO" (Profile-Guided Optimization) in the lexicon. (authored by fcambus).
[docs] Document "PGO" (Profile-Guided Optimization) in the lexicon.
Thu, Mar 16, 4:16 AM · Restricted Project, Restricted Project

Wed, Mar 15

fcambus committed rGd8df8710e127: [compiler-rt] Point UndefinedBehaviorSanitizer link to its own page. (authored by fcambus).
[compiler-rt] Point UndefinedBehaviorSanitizer link to its own page.
Wed, Mar 15, 9:06 AM · Restricted Project, Restricted Project

Feb 10 2023

fcambus committed rG5cec69bb43bc: [clang] Update Clang version from 16 to 17 in scan-build.1. (authored by fcambus).
[clang] Update Clang version from 16 to 17 in scan-build.1.
Feb 10 2023, 4:51 AM · Restricted Project, Restricted Project

Aug 9 2022

fcambus added a comment to D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD.

Agreed, that makes sense. Sorry for the noise.

Aug 9 2022, 8:22 AM · Restricted Project, Restricted Project

Aug 1 2022

fcambus committed rG892e6e2200d9: [clang] Update Clang version from 15 to 16 in scan-build.1. (authored by fcambus).
[clang] Update Clang version from 15 to 16 in scan-build.1.
Aug 1 2022, 1:36 AM · Restricted Project, Restricted Project

Jul 29 2022

fcambus abandoned D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD.
Jul 29 2022, 5:28 AM · Restricted Project, Restricted Project

Jul 3 2022

fcambus added a comment to D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD.

I am unsure it is useful to add a test for all OSxfuse_ld_value combinations, especially for an ELF OS like NetBSD which shares many characteristics with other ELF OSes. It will be overwhelming.
The option may be better added in a netbsd specific file.

Jul 3 2022, 11:59 AM · Restricted Project, Restricted Project

Jun 28 2022

fcambus requested review of D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD.
Jun 28 2022, 1:25 PM · Restricted Project, Restricted Project

Jun 27 2022

fcambus added a comment to D128620: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD.

It's best to switch to LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on layout at some point.

Jun 27 2022, 8:42 AM · Restricted Project, Restricted Project
fcambus committed rGaa89bb3435e0: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD (authored by fcambus).
[Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD
Jun 27 2022, 8:40 AM · Restricted Project, Restricted Project
fcambus closed D128620: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD.
Jun 27 2022, 8:40 AM · Restricted Project, Restricted Project

Jun 26 2022

fcambus requested review of D128620: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD.
Jun 26 2022, 3:34 PM · Restricted Project, Restricted Project
fcambus committed rG2ff4fb6573c1: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD (authored by fcambus).
[Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD
Jun 26 2022, 1:19 PM · Restricted Project, Restricted Project
fcambus closed D128512: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD.
Jun 26 2022, 1:19 PM · Restricted Project, Restricted Project
fcambus committed rG3caa32b26f5a: [Driver] Use Component in OpenBSD::getCompilerRT to find libraries (authored by blackgnezdo).
[Driver] Use Component in OpenBSD::getCompilerRT to find libraries
Jun 26 2022, 12:12 PM · Restricted Project, Restricted Project
fcambus closed D109051: Use Component in OpenBSD::getCompilerRT to find libraries.
Jun 26 2022, 12:12 PM · Restricted Project, Restricted Project

Jun 24 2022

fcambus requested review of D128512: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD.
Jun 24 2022, 3:09 AM · Restricted Project, Restricted Project
fcambus committed rGa129a371610d: [clang] Update Clang version from 14 to 15 in scan-build.1. (authored by fcambus).
[clang] Update Clang version from 14 to 15 in scan-build.1.
Jun 24 2022, 2:11 AM · Restricted Project, Restricted Project

Mar 23 2022

fcambus committed rG45c673816e18: [compiler-rt] Remove forgotten mention of SVN modules, LLVM now uses Git. (authored by fcambus).
[compiler-rt] Remove forgotten mention of SVN modules, LLVM now uses Git.
Mar 23 2022, 7:30 AM · Restricted Project

Mar 21 2022

fcambus committed rGbc01d8fbcfd3: [compiler-rt] Remove mentions of AuroraUX in code comments and docs. (authored by fcambus).
[compiler-rt] Remove mentions of AuroraUX in code comments and docs.
Mar 21 2022, 2:07 PM · Restricted Project

Dec 20 2021

fcambus committed rGf6ba5c4d5f22: [llvm-readobj] Check ELFType value first when checking for OpenBSD notes. (authored by fcambus).
[llvm-readobj] Check ELFType value first when checking for OpenBSD notes.
Dec 20 2021, 7:33 AM

Dec 2 2021

fcambus committed rG878ff1f9f85f: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes. (authored by fcambus).
[llvm-readobj] Add support for machine-independent NetBSD ELF core notes.
Dec 2 2021, 3:28 AM
fcambus closed D114635: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes..
Dec 2 2021, 3:28 AM · Restricted Project
fcambus committed rG69deb1371fd4: Use cc/c++ instead of gcc/g++ on FreeBSD. (authored by fcambus).
Use cc/c++ instead of gcc/g++ on FreeBSD.
Dec 2 2021, 2:53 AM
fcambus closed D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD..
Dec 2 2021, 2:53 AM · Restricted Project

Nov 29 2021

fcambus added a reviewer for D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD.: krytarowski.
Nov 29 2021, 2:56 AM · Restricted Project
fcambus updated the diff for D114635: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes..

Check ELFType == ELF::ET_CORE first in getNoteTypeName().

Nov 29 2021, 12:24 AM · Restricted Project

Nov 27 2021

fcambus added a comment to D114635: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes..

Here is a new revision with the trailing spaces removed and linting
issue fixed, and updated tests.

Nov 27 2021, 10:32 AM · Restricted Project
fcambus updated the diff for D114635: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes..
Nov 27 2021, 10:31 AM · Restricted Project

Nov 26 2021

fcambus requested review of D114635: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes..
Nov 26 2021, 5:16 AM · Restricted Project

Nov 24 2021

fcambus requested review of D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD..
Nov 24 2021, 5:32 AM · Restricted Project

Nov 2 2021

fcambus committed rG650311737eee: [llvm-readobj] Add support for reading OpenBSD ELF core notes. (authored by fcambus).
[llvm-readobj] Add support for reading OpenBSD ELF core notes.
Nov 2 2021, 2:19 AM
fcambus closed D111966: [llvm-readobj] Add support for reading OpenBSD ELF core notes..
Nov 2 2021, 2:19 AM · Restricted Project

Nov 1 2021

fcambus updated the diff for D111966: [llvm-readobj] Add support for reading OpenBSD ELF core notes..

Combine the two if checks in getNoteTypeName().

Nov 1 2021, 2:59 PM · Restricted Project

Oct 30 2021

fcambus committed rG6ecd4a4d01a3: [clang][scan-build] Use uname -s to detect the operating system. (authored by fcambus).
[clang][scan-build] Use uname -s to detect the operating system.
Oct 30 2021, 2:28 PM
fcambus closed D111797: [clang][scan-build] Use uname -s to detect the operating system..
Oct 30 2021, 2:27 PM · Restricted Project

Oct 29 2021

fcambus added a comment to D111797: [clang][scan-build] Use uname -s to detect the operating system..

Sure, I reverted to the previous revision.

Oct 29 2021, 4:06 AM · Restricted Project
fcambus updated the diff for D111797: [clang][scan-build] Use uname -s to detect the operating system..
Oct 29 2021, 4:05 AM · Restricted Project

Oct 24 2021

fcambus abandoned D109687: [compiler-rt] Enable building libclang_rt.profile on OpenBSD..
Oct 24 2021, 8:51 AM · Restricted Project
fcambus updated the diff for D111966: [llvm-readobj] Add support for reading OpenBSD ELF core notes..
Oct 24 2021, 6:10 AM · Restricted Project

Oct 21 2021

fcambus committed rGb471e25a5924: [clang] Support __float128 on DragonFlyBSD. (authored by fcambus).
[clang] Support __float128 on DragonFlyBSD.
Oct 21 2021, 2:20 AM
fcambus closed D111760: [clang] Support __float128 on DragonFlyBSD..
Oct 21 2021, 2:20 AM · Restricted Project
fcambus committed rG9635b2951da1: [docs] Fix broken link rendering in the LLVM Coding Standards. (authored by fcambus).
[docs] Fix broken link rendering in the LLVM Coding Standards.
Oct 21 2021, 2:13 AM

Oct 19 2021

fcambus added inline comments to D111760: [clang] Support __float128 on DragonFlyBSD..
Oct 19 2021, 2:42 PM · Restricted Project

Oct 17 2021

fcambus added a comment to D111797: [clang][scan-build] Use uname -s to detect the operating system..

I'm not a Perl guy but I'm wondering about simplifying what it is doing there to just uname -s eq 'OpenBSD'?

Oct 17 2021, 12:43 PM · Restricted Project
fcambus updated the diff for D111797: [clang][scan-build] Use uname -s to detect the operating system..

Avoid using regexps and use the 'eq' operator for doing string comparison.

Oct 17 2021, 12:42 PM · Restricted Project
fcambus added a comment to D109051: Use Component in OpenBSD::getCompilerRT to find libraries.

Any update on this?

Oct 17 2021, 9:24 AM · Restricted Project, Restricted Project
fcambus requested review of D111966: [llvm-readobj] Add support for reading OpenBSD ELF core notes..
Oct 17 2021, 9:19 AM · Restricted Project

Oct 16 2021

fcambus committed rG4d7c7d87e46e: [docs] Mention DragonFlyBSD as a supported platform for LLVM. (authored by fcambus).
[docs] Mention DragonFlyBSD as a supported platform for LLVM.
Oct 16 2021, 4:21 AM
fcambus closed D111758: [docs] Mention DragonFlyBSD as a supported platform for LLVM..
Oct 16 2021, 4:21 AM · Restricted Project

Oct 15 2021

fcambus committed rGecef0359538c: [Driver][NetBSD] Use Triple reference instead of ToolChain.getTriple(). (authored by fcambus).
[Driver][NetBSD] Use Triple reference instead of ToolChain.getTriple().
Oct 15 2021, 7:38 AM
fcambus closed D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple()..
Oct 15 2021, 7:38 AM · Restricted Project
fcambus added a comment to D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple()..

Yes, I rebuilt everything with the updated diff and ran check-clang-driver.

Oct 15 2021, 2:20 AM · Restricted Project
fcambus added inline comments to D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple()..
Oct 15 2021, 1:47 AM · Restricted Project
fcambus updated the diff for D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple()..

Use 'Triple' instead of 'T'.

Oct 15 2021, 1:46 AM · Restricted Project

Oct 14 2021

fcambus committed rG8ecbcd058fbd: [Driver][Darwin] Use T reference instead of getToolChain().getTriple(). (authored by fcambus).
[Driver][Darwin] Use T reference instead of getToolChain().getTriple().
Oct 14 2021, 12:32 PM
fcambus closed D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple()..
Oct 14 2021, 12:32 PM · Restricted Project
fcambus committed rGf7a3214306cb: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain(). (authored by fcambus).
[Driver][WebAssembly] Use ToolChain reference instead of getToolChain().
Oct 14 2021, 10:45 AM
fcambus closed D111786: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain()..
Oct 14 2021, 10:45 AM · Restricted Project
fcambus requested review of D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple()..
Oct 14 2021, 7:12 AM · Restricted Project
fcambus requested review of D111797: [clang][scan-build] Use uname -s to detect the operating system..
Oct 14 2021, 5:41 AM · Restricted Project
fcambus requested review of D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple()..
Oct 14 2021, 5:02 AM · Restricted Project
fcambus requested review of D111786: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain()..
Oct 14 2021, 2:48 AM · Restricted Project

Oct 13 2021

fcambus requested review of D111760: [clang] Support __float128 on DragonFlyBSD..
Oct 13 2021, 3:14 PM · Restricted Project
fcambus requested review of D111758: [docs] Mention DragonFlyBSD as a supported platform for LLVM..
Oct 13 2021, 3:03 PM · Restricted Project

Oct 9 2021

fcambus committed rG6417260a57dd: [Driver][OpenBSD] Use ToolChain reference instead of getToolChain(). (authored by fcambus).
[Driver][OpenBSD] Use ToolChain reference instead of getToolChain().
Oct 9 2021, 4:23 AM
fcambus closed D111462: [Driver][OpenBSD] Use ToolChain reference instead of getToolChain()..
Oct 9 2021, 4:23 AM · Restricted Project

Oct 8 2021

fcambus requested review of D111462: [Driver][OpenBSD] Use ToolChain reference instead of getToolChain()..
Oct 8 2021, 1:25 PM · Restricted Project
fcambus committed rG1f90b365bd62: [Driver][NetBSD] Use ToolChain reference instead of getToolChain(). (authored by fcambus).
[Driver][NetBSD] Use ToolChain reference instead of getToolChain().
Oct 8 2021, 2:14 AM
fcambus closed D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain()..
Oct 8 2021, 2:14 AM · Restricted Project
fcambus added inline comments to D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain()..
Oct 8 2021, 1:30 AM · Restricted Project
fcambus updated the diff for D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain()..

Also define and use ToolChain reference in netbsd::Assembler::ConstructJob().

Oct 8 2021, 1:29 AM · Restricted Project

Oct 7 2021

fcambus requested review of D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain()..
Oct 7 2021, 12:18 PM · Restricted Project

Sep 30 2021

fcambus added a comment to D110836: [CMake] Fix typo in error message for LLD in bootstrap builds..

@xgupta Yes, I of course have plans to continue contributing to LLVM. I will apply for commit access, thanks for the suggestion!

Sep 30 2021, 9:22 AM · Restricted Project
fcambus requested review of D110836: [CMake] Fix typo in error message for LLD in bootstrap builds..
Sep 30 2021, 7:56 AM · Restricted Project

Sep 29 2021

fcambus requested review of D110763: [clang] Update Clang version from 13 to 14 in scan-build.1..
Sep 29 2021, 1:04 PM · Restricted Project
fcambus requested review of D110750: [clang] Fix sentence in the usage section of ThinLTO docs..
Sep 29 2021, 11:56 AM · Restricted Project
fcambus requested review of D110715: [clang] Fix library name (libsupc++) in the admonition note..
Sep 29 2021, 6:49 AM · Restricted Project

Sep 25 2021

fcambus added a comment to D110035: [CMake] Add detection for the mold linker in AddLLVM.cmake..

@MaskRay I don't have commit access, could you commit this for me? Thanks!

Sep 25 2021, 3:53 AM · Restricted Project

Sep 24 2021

fcambus added a comment to D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils..

I can push this for you @fcambus.

Sep 24 2021, 5:53 AM · Restricted Project
fcambus updated the diff for D110035: [CMake] Add detection for the mold linker in AddLLVM.cmake..

This revision drops the unneeded line setting LLVM_LINKER_IS_GOLD.

Sep 24 2021, 5:09 AM · Restricted Project
fcambus added a comment to D110035: [CMake] Add detection for the mold linker in AddLLVM.cmake..

Why do we want to keep identifying it as Gold? I guess it's because additional work needs to happen if we don't just treat it as Gold?

Sep 24 2021, 5:05 AM · Restricted Project

Sep 23 2021

fcambus updated the diff for D109663: [docs] Document the --print-passes flag in opt..

Rebased on top of current main branch.

Sep 23 2021, 1:48 PM · Restricted Project

Sep 19 2021

fcambus requested review of D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils..
Sep 19 2021, 9:29 AM · Restricted Project
fcambus requested review of D110039: [compiler-rt] Use portable "#!/usr/bin/env bash" shebang for tests..
Sep 19 2021, 9:02 AM · Restricted Project
fcambus requested review of D110035: [CMake] Add detection for the mold linker in AddLLVM.cmake..
Sep 19 2021, 6:32 AM · Restricted Project

Sep 18 2021

fcambus added a comment to D109687: [compiler-rt] Enable building libclang_rt.profile on OpenBSD..

Do ninja check-profile tests pass?

Sep 18 2021, 6:07 AM · Restricted Project

Sep 13 2021

fcambus requested review of D109687: [compiler-rt] Enable building libclang_rt.profile on OpenBSD..
Sep 13 2021, 6:45 AM · Restricted Project

Sep 12 2021

fcambus requested review of D109663: [docs] Document the --print-passes flag in opt..
Sep 12 2021, 1:55 PM · Restricted Project

Sep 9 2021

fcambus added a reviewer for D109349: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD.: sylvestre.ledru.
Sep 9 2021, 6:59 AM · Restricted Project

Sep 7 2021

fcambus requested review of D109349: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD..
Sep 7 2021, 3:14 AM · Restricted Project
fcambus requested review of D109346: [compiler-rt] Document that builtins is known to work on OpenBSD..
Sep 7 2021, 1:09 AM · Restricted Project

Sep 3 2021

fcambus requested review of D109244: [clang] Allow the OpenBSD driver to link the libclang_rt.profile library..
Sep 3 2021, 9:36 AM · Restricted Project

Jul 27 2021

fcambus requested review of D106867: [scan-build] Fix a typo in the manual page: s/contraint/constraint..
Jul 27 2021, 5:44 AM · Restricted Project

Jul 23 2021

fcambus added a reviewer for D106664: [clang][docs] Fix typos in Options.td and regen ClangCommandLineReference.rst.: mgorny.
Jul 23 2021, 8:33 AM · Restricted Project
fcambus requested review of D106664: [clang][docs] Fix typos in Options.td and regen ClangCommandLineReference.rst..
Jul 23 2021, 7:19 AM · Restricted Project