This is an archive of the discontinued LLVM Phabricator instance.

docs: Document workaround for arcanist failures
ClosedPublic

Authored by tstellar on Oct 1 2021, 2:45 PM.

Diff Detail

Event Timeline

tstellar requested review of this revision.Oct 1 2021, 2:45 PM
tstellar created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2021, 2:45 PM
smeenai accepted this revision.Oct 1 2021, 2:49 PM
smeenai added a subscriber: smeenai.

LGTM, thanks.

This revision is now accepted and ready to land.Oct 1 2021, 2:49 PM

Would we want to put up the commit in a fork that we control, so that we're not relying on someone else's fork (which may go away in the future)?

ctetreau added a subscriber: ctetreau.EditedOct 1 2021, 2:56 PM

Would we want to put up the commit in a fork that we control, so that we're not relying on someone else's fork (which may go away in the future)?

+1

Ideally, a fork could live in the LLVM github org with this patch applied.

We discussed this at the last board meeting and decided that we don't want to be hosting non-LLVM projects in our GitHub organization. We can always update the docs if this workaround stops working.

We discussed this at the last board meeting and decided that we don't want to be hosting non-LLVM projects in our GitHub organization. We can always update the docs if this workaround stops working.

This is weird, we already decided to host the repo for our own fork of Phabricator: https://github.com/llvm/phabricator

We discussed this at the last board meeting and decided that we don't want to be hosting non-LLVM projects in our GitHub organization. We can always update the docs if this workaround stops working.

This is weird, we already decided to host the repo for our own fork of Phabricator: https://github.com/llvm/phabricator

I don't think anyone was aware of this, I will raise the question again.

In the meantime, I'm going to commit this so that we have a documented solution.

Any news on this? As @mehdi_amini mentions, we have a fork. I would think that the ideal solution is to just merge that PR into our fork, then update the instructions to say to use our repo for arcanist. If our fork of phabricator is not long for this world, I don't think this would make getting rid of it in the future significantly harder.

Did you get any clarification on this issue @tstellar?

This revision was automatically updated to reflect the committed changes.

In the meantime, I'm going to commit this so that we have a documented solution.

I pushed this in 509fe20fbca767a65b9c27750ea9d372ed2ab05a

Any news on this? As @mehdi_amini mentions, we have a fork.

Sorry: we only have a fork for the server side Phabricator software. We'd have to fork the arcanist repo as well.

OK, thanks for the update!