This is an archive of the discontinued LLVM Phabricator instance.

[fir][NFC] Update doc for pinned attr in fir.alloca
ClosedPublic

Authored by clementval on Sep 30 2021, 1:24 PM.

Details

Summary

Add descritpion for the attribute added in D110815.

Event Timeline

clementval created this revision.Sep 30 2021, 1:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2021, 1:24 PM
clementval requested review of this revision.Sep 30 2021, 1:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2021, 1:24 PM

Thanks @clementval for adding the doc and also for upstreaming the pinned attribute change. Have Nit comment.

flang/include/flang/Optimizer/Dialect/FIROps.td
128
This revision is now accepted and ready to land.Sep 30 2021, 1:43 PM

Address nit comment

clementval marked an inline comment as done.EditedOct 1 2021, 12:15 AM

Thanks @clementval for adding the doc and also for upstreaming the pinned attribute change. Have Nit comment.

Thanks for the reviews. By the way, I'm trying to preserve as much as possible the authorship from fir-dev. So the pinned attr was committed with you as the author.

This revision was automatically updated to reflect the committed changes.