When reading 32 bits a 32-bit shift would be executed.
This is undefined behaviour, but in this case we can just replace the
entire scratch value to avoid it.
Paths
| Differential D110769
[M68k] Avoid UB in disassembler ClosedPublic Authored by ricky26 on Sep 29 2021, 1:18 PM.
Details
Summary When reading 32 bits a 32-bit shift would be executed. This is undefined behaviour, but in this case we can just replace the
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Sep 29 2021, 2:05 PM This revision was landed with ongoing or failed builds.Sep 29 2021, 2:12 PM Closed by commit rGe1e3b6ee7297: [M68k] Avoid UB in disassembler (authored by ricky26). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 376022 llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp
|
clang-tidy: error: 'M68k.h' file not found [clang-diagnostic-error]
not useful