[compiler-rt] Add target dependencies to run ORC tests

[jackoalan]

Summary

check-orc-rt has no cmake target dependency on orc or llvm-jitlink. Unless starting with a complete all build, the orc regression tests in compiler-rt may fail due to build dependencies.

[lhames]

LGTM. Thanks Jack!

Do you have commit access? If not, please let me know and I can commit on your behalf.

[jackoalan]

I do not have commit access, it'd be great if you'd do that. --author="Jack Andersen <[e-mail]>"

[lhames]

Thanks Jack. I'm not sure what LLVM's policy is with regards to --author, so I've committed with a standard attribution in 1380eae59020. I'll ask around about --author for future commits.

[jackoalan]

In D110659#3029327, @lhames wrote:

Thanks Jack. I'm not sure what LLVM's policy is with regards to --author

It appears this policy is documented in https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator. It's fine if it's already committed though.

[lhames]

In D110659#3029379, @jackoalan wrote:

In D110659#3029327, @lhames wrote:

Thanks Jack. I'm not sure what LLVM's policy is with regards to --author

It appears this policy is documented in https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator. It's fine if it's already committed though.

So it is. Thanks very much for pointing me to that, and sorry for not having used it this time around. I'll use --author for future commits.

[jackoalan]

Not a problem, thank you for the quick turnaround :)

compiler-rt/test/CMakeLists.txt

 
 # When ANDROID, we build tests with the host compiler (i.e. CMAKE_C_COMPILER),
 # and run tests with tools from the host toolchain.
 if(NOT ANDROID)
   if(NOT COMPILER_RT_STANDALONE_BUILD AND NOT LLVM_RUNTIMES_BUILD)
     # Use LLVM utils and Clang from the same build tree.
     list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS
       clang clang-resource-headers FileCheck count not llvm-config llvm-nm llvm-objdump
-      llvm-readelf llvm-readobj llvm-size llvm-symbolizer compiler-rt-headers sancov)
+      llvm-readelf llvm-readobj llvm-size llvm-symbolizer compiler-rt-headers sancov
+      llvm-jitlink)
     if (WIN32)
       list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS KillTheDoctor)
     endif()
   endif()
   # Tests use C++ standard library headers.
   if (TARGET cxx-headers OR HAVE_LIBCXX)
     list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS cxx-headers)
   endif()

compiler-rt/test/orc/CMakeLists.txt

 set(ORC_LIT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
 
 set(ORC_TESTSUITES)
 set(ORC_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
 
 set(ORC_TEST_ARCH ${ORC_SUPPORTED_ARCH})
 if (COMPILER_RT_BUILD_ORC AND COMPILER_RT_HAS_ORC)
+  list(APPEND ORC_TEST_DEPS orc)
   foreach(arch ${ORC_TEST_ARCH})
     set(ORC_TEST_TARGET_ARCH ${arch})
     string(TOLOWER "-${arch}-${OS_NAME}" ORC_TEST_CONFIG_SUFFIX)
     get_test_cc_for_arch(${arch} ORC_TEST_TARGET_CC ORC_TEST_TARGET_CFLAGS)
     string(TOUPPER ${arch} ARCH_UPPER_CASE)
     set(CONFIG_NAME ${ARCH_UPPER_CASE}${OS_NAME}Config)
 
     configure_lit_site_cfg(