Page MenuHomePhabricator

[compiler-rt] Add target dependencies to run ORC tests
ClosedPublic

Authored by jackoalan on Sep 28 2021, 2:30 PM.

Details

Summary

check-orc-rt has no cmake target dependency on orc or llvm-jitlink. Unless starting with a complete all build, the orc regression tests in compiler-rt may fail due to build dependencies.

Diff Detail

Event Timeline

jackoalan created this revision.Sep 28 2021, 2:30 PM
jackoalan requested review of this revision.Sep 28 2021, 2:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 28 2021, 2:30 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
jackoalan edited the summary of this revision. (Show Details)Sep 28 2021, 2:31 PM
jackoalan edited the summary of this revision. (Show Details)Sep 28 2021, 2:39 PM

LGTM. Thanks Jack!

Do you have commit access? If not, please let me know and I can commit on your behalf.

I do not have commit access, it'd be great if you'd do that. --author="Jack Andersen <jackoalan@gmail.com>"

This revision was not accepted when it landed; it landed in state Needs Review.Sep 28 2021, 10:16 PM
This revision was automatically updated to reflect the committed changes.

Thanks Jack. I'm not sure what LLVM's policy is with regards to --author, so I've committed with a standard attribution in 1380eae59020. I'll ask around about --author for future commits.

Thanks Jack. I'm not sure what LLVM's policy is with regards to --author

It appears this policy is documented in https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator. It's fine if it's already committed though.

Thanks Jack. I'm not sure what LLVM's policy is with regards to --author

It appears this policy is documented in https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator. It's fine if it's already committed though.

So it is. Thanks very much for pointing me to that, and sorry for not having used it this time around. I'll use --author for future commits.

Not a problem, thank you for the quick turnaround :)