Page MenuHomePhabricator

Rename target block size to min task size for clarity.
ClosedPublic

Authored by bakhtiyarneyman on Sep 27 2021, 6:20 PM.

Diff Detail

Event Timeline

bakhtiyarneyman requested review of this revision.Sep 27 2021, 6:20 PM
bakhtiyarneyman edited the summary of this revision. (Show Details)Sep 27 2021, 6:23 PM
ezhulenev added inline comments.Sep 28 2021, 10:30 AM
mlir/lib/Dialect/Async/Transforms/AsyncParallelFor.cpp
98

variable_ is not compatible with the style guide, does the name shadowing warnings show up anywhere

687

minTaskSizeCst is more consistent with other constants in the mlir code base

Appease clang.

ezhulenev accepted this revision.Sep 28 2021, 2:33 PM
This revision is now accepted and ready to land.Sep 28 2021, 2:33 PM