This is part of https://github.com/dlang/projects/issues/81
Enable support for demangling D symbols using llvm-cxxfilt tool
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Differential D110577
[llvm-cxxfilt] Enable support for D programming language demangling ljmf00 on Sep 27 2021, 1:00 PM. Authored by
Details
This is part of https://github.com/dlang/projects/issues/81 Enable support for demangling D symbols using llvm-cxxfilt tool Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Diff Detail Event TimelineComment Actions One nit, otherwise LGTM.
Comment Actions Updated the diff to add the requested header. Also added a simpler test to be able to change the parent diff and stack with the diff implementing simple symbols.
Comment Actions Since support for llvm-cxxfilt was synced with Demangle.cpp logic on https://reviews.llvm.org/D110664, this doesn't makes sense anymore. Tests are going to be added on https://reviews.llvm.org/D111414 instead. |
I don't think you need to include this header - strncmp is already used in this file, so it's clearly being included through the existing include hierarchy. See also https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible.