Page MenuHomePhabricator

[libc++][format][1/6] Reduce binary size.
Needs ReviewPublic

Authored by Mordante on Sun, Sep 26, 4:53 AM.

Details

Reviewers
ldionne
vitaut
Group Reviewers
Restricted Project
Summary

This removes the format_args_t from <format> and adjusts the type of
the format_args for the vformat_to overloads.

The format_context uses a back_insert_iterator<string> therefore the
new output_iterator function uses a string as its temporary storage
buffer. This isn't ideal. The next patches in this series will improve
this. These improvements make it easy to also improve format_to_n and
formatted_size.

This addresses P2216 6. Binary size.
P2216 5. Compile-time checks are not part of this change.

Implements parts of:

  • P2216 std::format improvements

Depends on D103670

Diff Detail

Event Timeline

Mordante created this revision.Sun, Sep 26, 4:53 AM
Mordante requested review of this revision.Sun, Sep 26, 4:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Sep 26, 4:53 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante updated this revision to Diff 378267.Fri, Oct 8, 9:18 AM

The patches below this one had errors with Buildkite applying patches.
Rebase since all dependencies have landed.

Mordante updated this revision to Diff 380165.Sat, Oct 16, 3:54 AM

Rebased to test with wchar_t changes.