This is an archive of the discontinued LLVM Phabricator instance.

Differential D110408

[update_llc_test_checks] Baseline test for D100027
ClosedPublic

Authored by arichardson on Sep 24 2021, 5:56 AM.

Details

Reviewers
None
Commits
rGee3109b044a2: [update_llc_test_checks] Baseline test for D100027
Summary

Show that we fail to generate CHECK lines for MIPS64 functions with EH.

Diff Detail

Unit TestsFailed

TimeTest
90 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-cxa-atexit.S
90 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-static-initializer.S
90 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-tls.S

Event Timeline

arichardson created this revision.Sep 24 2021, 5:56 AM
Herald added subscribers: atanasyan, jrtc27, sdardis. · View Herald TranscriptSep 24 2021, 5:56 AM
arichardson requested review of this revision.Sep 24 2021, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2021, 5:56 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
arichardson mentioned this in D100027: [update_llc_test_checks.py] Fix MIPS ASM regex for functions with EH.Sep 24 2021, 5:56 AM
arichardson added a child revision: D100027: [update_llc_test_checks.py] Fix MIPS ASM regex for functions with EH.Sep 24 2021, 5:57 AM
Harbormaster completed remote builds in B125545: Diff 374817.Sep 24 2021, 6:15 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 28 2021, 9:57 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGee3109b044a2: [update_llc_test_checks] Baseline test for D100027 (authored by arichardson). · Explain Why
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rGee3109b044a2: [update_llc_test_checks] Baseline test for D100027.

Revision Contents

PathSize
llvm/
test/
tools/
UpdateTestChecks/
update_llc_test_checks/
Inputs/
15 lines
16 lines
5 lines

Diff 374817

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/mips64_eh.ll

  • This file was added.
; RUN: llc -mtriple=mips64-unknown-linux < %s | FileCheck %s
; FIXME: doesn't generate any CHECK lines
define i32 @main() personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*){
%1 = invoke i32 @foo() to label %good unwind label %bad
good:
ret i32 5
bad:
%2 = landingpad { i8*, i32 }
cleanup
resume { i8*, i32 } %2
}
declare i32 @foo()
declare i32 @__gxx_personality_v0(...)

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/mips64_eh.ll.expected

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc -mtriple=mips64-unknown-linux < %s | FileCheck %s
; FIXME: doesn't generate any CHECK lines
define i32 @main() personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*){
%1 = invoke i32 @foo() to label %good unwind label %bad
good:
ret i32 5
bad:
%2 = landingpad { i8*, i32 }
cleanup
resume { i8*, i32 } %2
}
declare i32 @foo()
declare i32 @__gxx_personality_v0(...)

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/mips64_eh.test

  • This file was added.
# REQUIRES: mips-registered-target
## Check that we handle MIPS64 assembly output with an EH asm prologue
# RUN: cp -f %S/Inputs/mips64_eh.ll %t.ll && %update_llc_test_checks %t.ll
# RUN: diff -u %S/Inputs/mips64_eh.ll.expected %t.ll