This is an archive of the discontinued LLVM Phabricator instance.

Differential D110371

[CSSPGO] Do not pass -fpseudo-probe-for-profiling to the linker.
ClosedPublic

Authored by hoy on Sep 23 2021, 3:44 PM.

Details

Reviewers
wenlei
wlei
Commits
rGe9d1a679a1c9: [CSSPGO] Do not pass -fpseudo-probe-for-profiling to the linker.
Summary

The correponding linker switch has been removed by https://reviews.llvm.org/D110209, so do not pass it in clang.

Diff Detail

Unit TestsFailed

TimeTest
150 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-cxa-atexit.S
220 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-static-initializer.S
420 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-tls.S

Event Timeline

hoy created this revision.Sep 23 2021, 3:44 PM
Herald added subscribers: ormris, modimo, wenlei and 2 others. · View Herald TranscriptSep 23 2021, 3:44 PM
hoy requested review of this revision.Sep 23 2021, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2021, 3:44 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hoy added reviewers: wenlei, wlei.Sep 23 2021, 3:44 PM
wenlei accepted this revision.Sep 23 2021, 3:44 PM
This revision is now accepted and ready to land.Sep 23 2021, 3:44 PM
This revision was landed with ongoing or failed builds.Sep 23 2021, 3:50 PM
Closed by commit rGe9d1a679a1c9: [CSSPGO] Do not pass -fpseudo-probe-for-profiling to the linker. (authored by hoy). · Explain Why
This revision was automatically updated to reflect the committed changes.
hoy added a commit: rGe9d1a679a1c9: [CSSPGO] Do not pass -fpseudo-probe-for-profiling to the linker..
Harbormaster completed remote builds in B125448: Diff 374684.Sep 23 2021, 4:05 PM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
5 lines
test/
Driver/

Diff 374684

clang/lib/Driver/ToolChains/CommonArgs.cpp

Show First 20 Lines • Show All 614 Lines • ▼ Show 20 Lines#endif
if (auto *A = Args.getLastArg(options::OPT_flegacy_pass_manager, if (auto *A = Args.getLastArg(options::OPT_flegacy_pass_manager,
options::OPT_fno_legacy_pass_manager)) { options::OPT_fno_legacy_pass_manager)) {
if (A->getOption().matches(options::OPT_flegacy_pass_manager)) if (A->getOption().matches(options::OPT_flegacy_pass_manager))
CmdArgs.push_back("-plugin-opt=legacy-pass-manager"); CmdArgs.push_back("-plugin-opt=legacy-pass-manager");
else else
CmdArgs.push_back("-plugin-opt=new-pass-manager"); CmdArgs.push_back("-plugin-opt=new-pass-manager");
} }
// Pass an option to enable pseudo probe emission.
if (Args.hasFlag(options::OPT_fpseudo_probe_for_profiling,
options::OPT_fno_pseudo_probe_for_profiling, false))
CmdArgs.push_back("-plugin-opt=pseudo-probe-for-profiling");
// Setup statistics file output. // Setup statistics file output.
SmallString<128> StatsFile = getStatsFileName(Args, Output, Input, D); SmallString<128> StatsFile = getStatsFileName(Args, Output, Input, D);
if (!StatsFile.empty()) if (!StatsFile.empty())
CmdArgs.push_back( CmdArgs.push_back(
Args.MakeArgString(Twine("-plugin-opt=stats-file=") + StatsFile)); Args.MakeArgString(Twine("-plugin-opt=stats-file=") + StatsFile));
addX86AlignBranchArgs(D, Args, CmdArgs, /*IsLTO=*/true); addX86AlignBranchArgs(D, Args, CmdArgs, /*IsLTO=*/true);
▲ Show 20 Lines • Show All 1,114 Lines • Show Last 20 Lines

clang/test/Driver/pseudo-probe-lto.c

  • This file was deleted.
// RUN: touch %t.o
// RUN: %clang -### %t.o -target x86_64-unknown-linux -flto -fpseudo-probe-for-profiling 2>&1 | FileCheck %s --check-prefix=PROBE
// RUN: %clang -### %t.o -target x86_64-unknown-linux -flto=thin -fpseudo-probe-for-profiling 2>&1 | FileCheck %s --check-prefix=PROBE
// RUN: %clang -### %t.o -target x86_64-unknown-linux -flto -fno-pseudo-probe-for-profiling -fpseudo-probe-for-profiling 2>&1 | FileCheck %s --check-prefix=PROBE
// RUN: %clang -### %t.o -target x86_64-unknown-linux -flto 2>&1 | FileCheck %s --check-prefix=NOPROBE
// RUN: %clang -### %t.o -target x86_64-unknown-linux -flto -fno-pseudo-probe-for-profiling 2>&1 | FileCheck %s --check-prefix=NOPROBE
// RUN: %clang -### %t.o -target x86_64-unknown-linux -flto -fpseudo-probe-for-profiling -fno-pseudo-probe-for-profiling 2>&1 | FileCheck %s --check-prefix=NOPROBE
// PROBE: -plugin-opt=pseudo-probe-for-profiling
// NOPROBE-NOT: -plugin-opt=pseudo-probe-for-profiling
clang/lib/Driver/ToolChains/CommonArgs.cpp