SBCC RFE: Support SBCC for Shared Library
Needs ReviewPublic
Actions

Authored by Hiralo on Sep 22 2021, 5:09 AM.

Details

Reviewers

vsk
Bigcheese
arphaman

Summary

commit bd251841c8cd8000e0a6271ae3555acd5f032b8e
Author: hiral
Date: Wed Sep 22 01:12:50 2021 -0700

SBCC RFE: Support SBCC for Shared Library

SBCC RFE: Support SBCC for Shared Library
Using '%n' format parameter for profile name templates, to insert the full
path of the current shared object into profile file names.

Internally using a linked list to gather all profile dumping functions
(there is one defined in each shared object) so they can be invoked with a
single function call.  Ensure the resulting directory paths are created
prior to dumping.

Author: Thom.Harp@netapp.com

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	220 ms	x64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-cxa-atexit.S Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-cxa-atexit.S
	190 ms	x64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-static-initializer.S Script: -- : 'RUN: at line 7'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-static-initializer.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-static-initializer.S
	170 ms	x64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-tls.S Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-tls.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-tls.S

Event Timeline

Hiralo created this revision.Sep 22 2021, 5:09 AM

Hiralo created this object with edit policy "Hiralo (Hiral)".

Herald added a subscriber: krytarowski. · View Herald TranscriptSep 22 2021, 5:09 AM

Hiralo requested review of this revision.Sep 22 2021, 5:09 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2021, 5:09 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

Harbormaster completed remote builds in B125089: Diff 374186.Sep 22 2021, 5:25 AM

Herald added a subscriber: ormris. · View Herald TranscriptSep 22 2021, 5:25 AM

Hiralo added reviewers: vsk, Bigcheese, arphaman.Sep 22 2021, 7:02 AM

alanphipps added a subscriber: alanphipps.Sep 22 2021, 7:39 AM

Hi @Hiralo, could you share some of the use cases for this feature? What were the pros/cons of any alternatives you considered (e.g. the %m/%c modes)?

Edit: I just noticed your thread "llvm-dev] compiler-rt RFE to support creating profraw for each Shared Library" on llvm-dev; let's follow up there.

ormris removed a subscriber: ormris.Jan 24 2022, 11:43 AM