This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Extract adding symbols for UUID/File/Frame (NFC)
ClosedPublic

Authored by JDevlieghere on Sep 17 2021, 3:54 PM.

Details

Summary

This moves the logic for adding symbols based on UUID, file and frame into little helper functions. This is in preparation for D110011.

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Sep 17 2021, 3:54 PM
JDevlieghere created this revision.
labath accepted this revision.Sep 19 2021, 11:52 PM

seems straight-forward enough

lldb/source/Commands/CommandObjectTarget.cpp
4203

Do we need to pass the target around? I would assume that can be retrieved from m_exe_ctx as well..

This revision is now accepted and ready to land.Sep 19 2021, 11:52 PM
JDevlieghere marked an inline comment as done.Sep 20 2021, 8:49 AM
JDevlieghere added inline comments.
lldb/source/Commands/CommandObjectTarget.cpp
4203

Yup, I'll fix that before landing.

This revision was landed with ongoing or failed builds.Sep 20 2021, 9:08 AM
This revision was automatically updated to reflect the committed changes.
JDevlieghere marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2021, 9:08 AM