This is an archive of the discontinued LLVM Phabricator instance.

flang] Accept SIZE(assumed-rank, DIM=n)
ClosedPublic

Authored by klausler on Sep 16 2021, 1:11 PM.

Download Raw Diff

Details

Reviewers

vdonaldson
PeteSteinfeld

Commits

rG12ba72789747: [flang] Accept SIZE(assumed-rank, DIM=n)

Summary

[Silence a bogus error message about an out-of-range DIM= argument
when the argument is assumed-rank. (More generally, don't pretend
to be able to discern a shape of known rank for an assumed-rank
object.)

Diff Detail

Event Timeline

klausler created this revision.Sep 16 2021, 1:11 PM

Herald added a subscriber: jdoerfert. · View Herald TranscriptSep 16 2021, 1:11 PM

klausler requested review of this revision.Sep 16 2021, 1:11 PM

Harbormaster completed remote builds in B124266: Diff 373046.Sep 16 2021, 1:33 PM

Looks great!

This revision is now accepted and ready to land.Sep 16 2021, 2:44 PM

This revision was landed with ongoing or failed builds.Sep 17 2021, 9:00 AM

Closed by commit rG12ba72789747: [flang] Accept SIZE(assumed-rank, DIM=n) (authored by klausler). · Explain Why

This revision was automatically updated to reflect the committed changes.

klausler added a commit: rG12ba72789747: [flang] Accept SIZE(assumed-rank, DIM=n).

Herald added a project: Restricted Project. · View Herald TranscriptSep 17 2021, 9:00 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

Path

Size

flang/

lib/

Evaluate/

shape.cpp

8 lines

Diff 373046

flang/lib/Evaluate/shape.cpp

Context not available.
	[&](const semantics::ObjectEntityDetails &object) {	[&](const semantics::ObjectEntityDetails &object) {
	if (IsImpliedShape(symbol) && object.init()) {	if (IsImpliedShape(symbol) && object.init()) {
	return (*this)(object.init());	return (*this)(object.init());
		} else if (IsAssumedRank(symbol)) {
		Lint: Pre-merge checks Inline Actions clang-tidy: warning: do not use 'else' after 'return' [llvm-else-after-return] not useful Lint: Pre-merge checks: clang-tidy: warning: do not use 'else' after 'return' [llvm-else-after-return] [[https://github.
		return Result{};
	} else {	} else {
	int n{object.shape().Rank()};	int n{object.shape().Rank()};
	NamedEntity base{symbol};	NamedEntity base{symbol};
Context not available.
	}	}
	},	},
	[&](const semantics::AssocEntityDetails &assoc) {	[&](const semantics::AssocEntityDetails &assoc) {
	if (!assoc.rank()) {	if (assoc.rank()) { // SELECT RANK case
	return (*this)(assoc.expr());
	} else {
	int n{assoc.rank().value()};	int n{assoc.rank().value()};
	NamedEntity base{symbol};	NamedEntity base{symbol};
	return Result{CreateShape(n, base)};	return Result{CreateShape(n, base)};
		} else {
		Lint: Pre-merge checks Inline Actions clang-tidy: warning: do not use 'else' after 'return' [llvm-else-after-return] not useful Lint: Pre-merge checks: clang-tidy: warning: do not use 'else' after 'return' [llvm-else-after-return] [[https://github.
		return (*this)(assoc.expr());
	}	}
	},	},
	[&](const semantics::SubprogramDetails &subp) {	[&](const semantics::SubprogramDetails &subp) {
Context not available.