Page MenuHomePhabricator

[Bazel] Use posix definitions for FreeBSD
ClosedPublic

Authored by wamuir on Sep 16 2021, 1:04 PM.

Details

Summary

Presently, definitions default to those for Linux which are not defined for FreeBSD (HAVE_LSEEK64, HAVE_MALLINFO, etc.). Patch sets os_defines to posix definitions under FreeBSD.

Diff Detail

Event Timeline

wamuir created this revision.Sep 16 2021, 1:04 PM
wamuir requested review of this revision.Sep 16 2021, 1:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2021, 1:04 PM
GMNGeoffrey accepted this revision.Sep 16 2021, 1:05 PM
GMNGeoffrey added a subscriber: GMNGeoffrey.

Thanks :-) LGTM if pre-merge checks pass.

This revision is now accepted and ready to land.Sep 16 2021, 1:05 PM

Awesome, thanks so much

I'm guessing from your profile history that you don't have commit access? Need me to land this for you?

Correct, no commit access and yes that'd be great. Thanks again

The patch doesn't have authorship information attached, could you tell me what name and email you'd like me to use for the commit? (see https://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes)

Sorry about that. William Muir wamuir@gmail.com

This revision was automatically updated to reflect the committed changes.

Sorry about that. William Muir wamuir@gmail.com

No worries :-)