Page MenuHomePhabricator

[Zorg][PowerPC] Implement a TestSuiteBuilder
ClosedPublic

Authored by Conanap on Fri, Sep 10, 1:31 PM.

Details

Reviewers
gkistanova
jsji
saghir
Group Reviewers
Restricted Project
Commits
rZORG9d4301d25f09: [PowerPC] Implement a TestSuiteBuilder
Summary

This patch implements TestSuiteBuilder, which utilises
UnifiedTreeBuilder to build with ninja, and then checks
out llvm-test-suite, builds it and runs it.

The patch also changes the PPC RHEL bot to this new builder.

Patch has been tested on a local server.

Diff Detail

Event Timeline

Conanap created this revision.Fri, Sep 10, 1:31 PM

Thanks, Albion!

The patch looks good. There are few things, though.

  1. Could you remove unrelated changes to the .gitignore file, please? Please feel free to make a separate patch if you want this change in.
  1. jobs is a worker property, not a build configuration. We have it historically in old builders, but there is no need to keep it in new. Think of a case when different computers are used as workers for the same builder, one is stronger and could handle more parallel jobs, and the other one needs less. NinjaCommand handles the property; you can just remove the jobs arguments for your usage.

+ some inline comment.

zorg/buildbot/builders/TestSuiteBuilder.py
2

There is no need to rename the getCmakeWithNinjaBuildFactory as there is no name collision here.

Conanap updated this revision to Diff 372776.Wed, Sep 15, 12:42 PM
Conanap marked an inline comment as done.

Removed jobs option, removed .gitignore changes, removed import rename.

@gkistanova this should hopefully have addressed all your concerns. Please let me know if there's anything else, thanks!

Perfect! Thanks for making the changes!
Let me stage this for you for a day or two in case you will want to make some changes after seeing it in action.

@gkistanova Thanks! I left it on staging for a day and am pretty happy with where it's at. Let me know if there's anything else you want me to change before approval and commit. Thanks!

gkistanova accepted this revision.Mon, Sep 20, 2:47 PM

LGTM with a nit pick.
Please remove steps from the import and feel free to commit.

zorg/buildbot/builders/TestSuiteBuilder.py
4

You do not use steps, so you can remove it from the import.

This revision is now accepted and ready to land.Mon, Sep 20, 2:47 PM
This revision was landed with ongoing or failed builds.Tue, Sep 21, 7:34 AM
This revision was automatically updated to reflect the committed changes.

I've removed the steps import in the actual commit. Thanks!