Page MenuHomePhabricator

add a check-tsan-shared

Authored by ZijunZhao on Sep 10 2021, 11:13 AM.



add a check-tsan-shared in

Event Timeline

ZijunZhao created this revision.Sep 10 2021, 11:13 AM
ZijunZhao requested review of this revision.Sep 10 2021, 11:13 AM
vitalybuka added inline comments.Sep 10 2021, 11:30 AM

The patch itself is LGTM but we can't land it. "ninja tsan-shared" and "ninja check-tsan-shared" do not work in the HEAD and in D108394. We need to add them into cmake files before adding to the buildbot.

Also, let's call the target "tsan-dynamic" to match the naming convention established in asan.

ZijunZhao updated this revision to Diff 372367.Sep 13 2021, 4:39 PM
vitalybuka accepted this revision.Sep 30 2021, 12:20 PM

LGTM, but please wait day or so after landing D108394

This revision is now accepted and ready to land.Sep 30 2021, 12:20 PM