This is an archive of the discontinued LLVM Phabricator instance.

[asan] Fixed the jump to use the 4 byte offset version.
ClosedPublic

Authored by kstoimenov on Sep 8 2021, 10:08 AM.

Details

Summary

This should have been the 4 byte version in the first place. Unfortunatelly there is no easy way to add a test as both the 1 byte and 4 byte version are printed as 'jmp' in the assembly code.

Diff Detail

Unit TestsFailed

Event Timeline

kstoimenov created this revision.Sep 8 2021, 10:08 AM
kstoimenov requested review of this revision.Sep 8 2021, 10:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2021, 10:08 AM
kda accepted this revision.Sep 8 2021, 10:35 AM

Is there a test which require JMP_4? (I assume the 1->4 is about length of jump.)

This revision is now accepted and ready to land.Sep 8 2021, 10:35 AM

Is there a test which require JMP_4? (I assume the 1->4 is about length of jump.)

I found a failure at link time for some of the binaries in Google code base. So it will require some sort of "integration test", which will try to link the code. I am not aware that such infrastructure exists in LLVM, but I might be wrong.

kda added a comment.Sep 8 2021, 10:49 AM

I don't know, but the .ll tests get linked, so I assume there must be some
way to trigger the problem. Maybe not worth the effort.

This revision was landed with ongoing or failed builds.Sep 8 2021, 10:59 AM
This revision was automatically updated to reflect the committed changes.