This is an archive of the discontinued LLVM Phabricator instance.

Differential D109341

[OpenMP][libomptarget] Change synchronize_ty return type to int32_t
ClosedPublic

Authored by ye-luo on Sep 6 2021, 7:34 PM.

Details

Reviewers
jdoerfert
tianshilei1992
Commits
rG8e5c1b039eaf: [OpenMP][libomptarget] Change synchronize_ty return type to int32_t
Summary

Plugins always return int32_t. Stay consistent with other functions which return error status.

Diff Detail

Unit TestsFailed

TimeTest
1,330 msx64 debian > libomp.api::omp_get_wtime.c

Event Timeline

ye-luo created this revision.Sep 6 2021, 7:34 PM
Herald added subscribers: guansong, yaxunl. · View Herald TranscriptSep 6 2021, 7:34 PM
ye-luo requested review of this revision.Sep 6 2021, 7:34 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptSep 6 2021, 7:34 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
ye-luo added a reviewer: tianshilei1992.Sep 6 2021, 7:35 PM
tianshilei1992 accepted this revision.Sep 6 2021, 7:36 PM
This revision is now accepted and ready to land.Sep 6 2021, 7:36 PM
This revision was landed with ongoing or failed builds.Sep 6 2021, 7:39 PM
Closed by commit rG8e5c1b039eaf: [OpenMP][libomptarget] Change synchronize_ty return type to int32_t (authored by ye-luo). · Explain Why
This revision was automatically updated to reflect the committed changes.
ye-luo added a commit: rG8e5c1b039eaf: [OpenMP][libomptarget] Change synchronize_ty return type to int32_t.
Harbormaster completed remote builds in B122818: Diff 370984.Sep 6 2021, 8:12 PM

Revision Contents

PathSize
openmp/
libomptarget/
src/
2 lines

Diff 370984

openmp/libomptarget/src/rtl.h

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines typedef int32_t(run_region_async_ty)(int32_t, void *, void **, ptrdiff_t *,
int32_t, __tgt_async_info *); int32_t, __tgt_async_info *);
typedef int32_t(run_team_region_ty)(int32_t, void *, void **, ptrdiff_t *, typedef int32_t(run_team_region_ty)(int32_t, void *, void **, ptrdiff_t *,
int32_t, int32_t, int32_t, uint64_t); int32_t, int32_t, int32_t, uint64_t);
typedef int32_t(run_team_region_async_ty)(int32_t, void *, void **, typedef int32_t(run_team_region_async_ty)(int32_t, void *, void **,
ptrdiff_t *, int32_t, int32_t, ptrdiff_t *, int32_t, int32_t,
int32_t, uint64_t, int32_t, uint64_t,
__tgt_async_info *); __tgt_async_info *);
typedef int64_t(init_requires_ty)(int64_t); typedef int64_t(init_requires_ty)(int64_t);
typedef int64_t(synchronize_ty)(int32_t, __tgt_async_info *); typedef int32_t(synchronize_ty)(int32_t, __tgt_async_info *);
typedef int32_t (*register_lib_ty)(__tgt_bin_desc *); typedef int32_t (*register_lib_ty)(__tgt_bin_desc *);
typedef int32_t(supports_empty_images_ty)(); typedef int32_t(supports_empty_images_ty)();
typedef void(print_device_info_ty)(int32_t); typedef void(print_device_info_ty)(int32_t);
typedef void(set_info_flag_ty)(uint32_t); typedef void(set_info_flag_ty)(uint32_t);
typedef int32_t(create_event_ty)(int32_t, void **); typedef int32_t(create_event_ty)(int32_t, void **);
typedef int32_t(record_event_ty)(int32_t, void *, __tgt_async_info *); typedef int32_t(record_event_ty)(int32_t, void *, __tgt_async_info *);
typedef int32_t(wait_event_ty)(int32_t, void *, __tgt_async_info *); typedef int32_t(wait_event_ty)(int32_t, void *, __tgt_async_info *);
typedef int32_t(sync_event_ty)(int32_t, void *); typedef int32_t(sync_event_ty)(int32_t, void *);
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines