Page MenuHomePhabricator

[OpenMP][libomptarget][NFC] Change checkDeviceAndCtors return type to bool.
ClosedPublic

Authored by ye-luo on Sep 5 2021, 11:06 PM.

Details

Summary

What is exactly needed is only a boolean. Pulling OFFLOAD_SUCCESS/FAIL only adds confusion.

Diff Detail

Event Timeline

ye-luo created this revision.Sep 5 2021, 11:06 PM
ye-luo requested review of this revision.Sep 5 2021, 11:06 PM
Herald added a project: Restricted Project. · View Herald Transcript
grokos accepted this revision.Sep 7 2021, 11:49 AM
grokos added a subscriber: grokos.

LG. This can be considered NFC, can you put the [NFC] tag in the title?

This revision is now accepted and ready to land.Sep 7 2021, 11:49 AM
ye-luo retitled this revision from [OpenMP][libomptarget] Change checkDeviceAndCtors return type to bool. to [OpenMP][libomptarget][NFC] Change checkDeviceAndCtors return type to bool..Sep 7 2021, 12:01 PM