Page MenuHomePhabricator

[libc++][testing] Suppress new warnings about <experimental/coroutine>
AbandonedPublic

Authored by mumbleskates on Sep 4 2021, 6:26 PM.

Details

Reviewers
cjdb
Quuxplusone
Group Reviewers
Restricted Project
Summary

CI is currently failing with new builds of clang due to a warning that std::experimental::coroutine_traits is deprecated, but libc++ does not have <coroutine> yet.

Diff Detail

Event Timeline

mumbleskates created this revision.Sep 4 2021, 6:26 PM
mumbleskates requested review of this revision.Sep 4 2021, 6:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2021, 6:26 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
cjdb accepted this revision.Sep 4 2021, 6:28 PM

Seems obviously correct to me, but we should take this as a prod to get <coroutine> done.

Quuxplusone requested changes to this revision.Sep 4 2021, 6:50 PM
Quuxplusone added subscribers: ldionne, Quuxplusone.

This looks related to D108696, which is already reverted out of main (thanks @ldionne).
Anyway, surely if we want to give a warning about <experimental/coroutine>, we should do it by putting a #warning directive in libc++'s <experimental/coroutine> itself; there is no reason for the compiler to be warning here, is there?

This revision now requires changes to proceed.Sep 4 2021, 6:50 PM

This looks related to D108696, which is already reverted out of main (thanks @ldionne).

Is there something we can do to bump the compiler version on the CI then? It's a lot of work to confirm that these are the only failures. It looks like they're failing on Runtimes, MacOS x86_64, and the Apple back-deployment workers.

This looks related to D108696, which is already reverted out of main (thanks @ldionne).

Is there something we can do to bump the compiler version on the CI then? It's a lot of work to confirm that these are the only failures. It looks like they're failing on Runtimes, MacOS x86_64, and the Apple back-deployment workers.

I don't see this issue on the CI currently. So it seems Louis' revert fixed the issue.
@mumbleskates If your reviews still have this issue, try rebasing them to the latest main.

mumbleskates abandoned this revision.Sep 5 2021, 12:23 PM

Okay looks like this is probably resolved-ish by now.