This is an archive of the discontinued LLVM Phabricator instance.

Differential D109196

scudo: Only add no-omit-frame-pointer flags when the compiler supports them
ClosedPublic

Authored by tstellar on Sep 2 2021, 2:24 PM.

Details

Reviewers
cryptoad
dvyukov
Commits
rG9ee64c374605: scudo: Only add no-omit-frame-pointer flags when the compiler supports them

Diff Detail

Event Timeline

tstellar created this revision.Sep 2 2021, 2:24 PM
Herald added a subscriber: mgorny. · View Herald TranscriptSep 2 2021, 2:24 PM
tstellar requested review of this revision.Sep 2 2021, 2:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2021, 2:24 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B122399: Diff 370410.Sep 2 2021, 3:10 PM
cryptoad added inline comments.Sep 2 2021, 3:17 PM
compiler-rt/lib/scudo/standalone/CMakeLists.txt
127

-mno-omit-leaf-frame-pointer went away?

tstellar updated this revision to Diff 370701.Sep 3 2021, 10:35 PM

Add missing -mno-omit-leaf-frame-pointer flag

Harbormaster completed remote builds in B122606: Diff 370701.Sep 3 2021, 11:22 PM
cryptoad accepted this revision.Sep 4 2021, 9:41 AM

Thank you!

This revision is now accepted and ready to land.Sep 4 2021, 9:41 AM
• hafixo added a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:44 AM
• hafixo added a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:47 AM
thopre removed a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:47 AM
thopre removed a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:51 AM
Closed by commit rG9ee64c374605: scudo: Only add no-omit-frame-pointer flags when the compiler supports them (authored by tstellar). · Explain WhySep 8 2021, 9:11 PM
This revision was automatically updated to reflect the committed changes.
tstellar added a commit: rG9ee64c374605: scudo: Only add no-omit-frame-pointer flags when the compiler supports them.

Revision Contents

PathSize
compiler-rt/
lib/
scudo/
standalone/
6 lines

Diff 370410

compiler-rt/lib/scudo/standalone/CMakeLists.txt

Show First 20 Lines • Show All 118 Lines • ▼ Show 20 Lines
set(SCUDO_OBJECT_LIBS) set(SCUDO_OBJECT_LIBS)
if (COMPILER_RT_HAS_GWP_ASAN) if (COMPILER_RT_HAS_GWP_ASAN)
add_dependencies(scudo_standalone gwp_asan) add_dependencies(scudo_standalone gwp_asan)
list(APPEND SCUDO_OBJECT_LIBS list(APPEND SCUDO_OBJECT_LIBS
RTGwpAsan RTGwpAsanBacktraceLibc RTGwpAsanSegvHandler RTGwpAsan RTGwpAsanBacktraceLibc RTGwpAsanSegvHandler
RTGwpAsanOptionsParser) RTGwpAsanOptionsParser)
list(APPEND SCUDO_CFLAGS -DGWP_ASAN_HOOKS -fno-omit-frame-pointer append_list_if(COMPILER_RT_HAS_OMIT_FRAME_POINTER_FLAG -fno-omit-frame-pointer
cryptoadUnsubmitted
Not Done
ReplyInline Actions

-mno-omit-leaf-frame-pointer went away?

cryptoad: `-mno-omit-leaf-frame-pointer` went away?
-mno-omit-leaf-frame-pointer) SCUDO_CFLAGS)
list(APPEND SCUDO_CFLAGS -DGWP_ASAN_HOOKS)
endif() endif()
set(SCUDO_LINK_LIBS) set(SCUDO_LINK_LIBS)
append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread SCUDO_LINK_FLAGS) append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread SCUDO_LINK_FLAGS)
append_list_if(FUCHSIA zircon SCUDO_LINK_LIBS) append_list_if(FUCHSIA zircon SCUDO_LINK_LIBS)
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines