[sanitizer_common] Define wordexp_wrde_dooffs for Solaris

[ro]

Summary

The Solaris buildbots have been broken for some time:

In file included from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/compiler-rt/lib/asan/asan_interceptors.cpp:174:
/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4000:19: error: use of undeclared identifier 'wordexp_wrde_dooffs'
        ((flags & wordexp_wrde_dooffs) ? p->we_offs : 0) + p->we_wordc;
                  ^

This was caused by D108646; the fix is equivalent to D108838.

Tested on amd64-pc-solaris2.11 and sparcv9-sun-solaris2.11.

[justincady]

Thanks for fixing this, and I apologize that I missed this platform as well.

[ro]

In D109193#2981390, @justincady wrote:

Thanks for fixing this, and I apologize that I missed this platform as well.

Thanks. However, I'd argue that the fault primarily lies with the way compiler-rt is configured:

• The wordexp interceptor in sanitizer_common_interceptors.inc is guarded with SANITIZER_INTERCEPT_WORDEXP while...
• ... we have 3 declarations/definitions now of wordexp_wrde_dooffs: one in sanitizer_platform_limits_posix.h/.cpp, which despite the filename is Linux and macOS only and now two more in sanitizer_platform_limits_freebsd.h/.cpp and sanitizer_platform_limits_solaris.h/.cpp.

It's almost impossible not to get lost in that impenetrable maze.

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_solaris.h

struct __sanitizer_glob_t {
   char **gl_pathv;
   uptr gl_offs;
   char **gl_pathp;
   int gl_pathn;
 };
 
 extern int glob_nomatch;
 extern int glob_altdirfunc;
+extern const int wordexp_wrde_dooffs;
 
 extern unsigned path_max;
 
 struct __sanitizer_wordexp_t {
   uptr we_wordc;
   char **we_wordv;
   uptr we_offs;
   char **we_wordp;

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_solaris.cpp

else if (af == AF_INET6)
       return sizeof(struct in6_addr);
     else
       return 0;
   }
 
   unsigned struct_ElfW_Phdr_sz = sizeof(ElfW(Phdr));
 
   int glob_nomatch = GLOB_NOMATCH;
+  const int wordexp_wrde_dooffs = WRDE_DOOFFS;
 
   unsigned path_max = PATH_MAX;
 
   // ioctl arguments
   unsigned struct_ifreq_sz = sizeof(struct ifreq);
   unsigned struct_termios_sz = sizeof(struct termios);
   unsigned struct_winsize_sz = sizeof(struct winsize);