Page MenuHomePhabricator

justincady (Justin Cady)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2020, 9:35 AM (102 w, 2 d)

Recent Activity

Mon, Jul 11

justincady added a comment to D128842: [InstrProf] Mark __llvm_profile_runtime hidden to match libclang_rt.profile definition.

@MaskRay Does this change require any further review? If it is good to go, would you please land it for me? I don't have commit access.

Mon, Jul 11, 10:49 AM · Restricted Project, Restricted Project

Jun 30 2022

justincady updated the summary of D128842: [InstrProf] Mark __llvm_profile_runtime hidden to match libclang_rt.profile definition.
Jun 30 2022, 7:22 AM · Restricted Project, Restricted Project
justincady added inline comments to D128842: [InstrProf] Mark __llvm_profile_runtime hidden to match libclang_rt.profile definition.
Jun 30 2022, 7:21 AM · Restricted Project, Restricted Project
justincady updated the diff for D128842: [InstrProf] Mark __llvm_profile_runtime hidden to match libclang_rt.profile definition.

Remove special case for Windows based on MaskRay's comment.

Jun 30 2022, 7:19 AM · Restricted Project, Restricted Project

Jun 29 2022

justincady requested review of D128842: [InstrProf] Mark __llvm_profile_runtime hidden to match libclang_rt.profile definition.
Jun 29 2022, 11:25 AM · Restricted Project, Restricted Project

Jun 24 2022

justincady accepted D128482: [clang codegen] Add dso_local/hidden/etc. markings to VTT declarations.

Just to double check I tested this exact patch locally with the setup that found the problem. I confirmed it resolved that issue.

Jun 24 2022, 6:53 AM · Restricted Project, Restricted Project

Sep 2 2021

justincady accepted D109193: [sanitizer_common] Define wordexp_wrde_dooffs for Solaris.

Thanks for fixing this, and I apologize that I missed this platform as well.

Sep 2 2021, 6:09 PM · Restricted Project

Aug 26 2021

justincady accepted D108754: [sanitizers] Fix FreeBSD compilation after d568e5325c744dadf08729aee0819a8954a955f5.

Thanks for fixing this. When I saw <wordexp.h> conditionally included for everything except Android, I mistakenly assumed Android was the only platform that needed to be handled differently.

Aug 26 2021, 6:03 AM · Restricted Project

Aug 24 2021

justincady added inline comments to D108646: [MSAN] Fix wordexp interception when WRDE_DOOFFS is used.
Aug 24 2021, 2:41 PM · Restricted Project
justincady added inline comments to D108646: [MSAN] Fix wordexp interception when WRDE_DOOFFS is used.
Aug 24 2021, 1:21 PM · Restricted Project
justincady added inline comments to D108646: [MSAN] Fix wordexp interception when WRDE_DOOFFS is used.
Aug 24 2021, 1:02 PM · Restricted Project
justincady added a comment to D108646: [MSAN] Fix wordexp interception when WRDE_DOOFFS is used.

Correct, I do not have commit access. Thanks for reviewing and landing the patch.

Aug 24 2021, 12:54 PM · Restricted Project
justincady requested review of D108646: [MSAN] Fix wordexp interception when WRDE_DOOFFS is used.
Aug 24 2021, 10:32 AM · Restricted Project

Jul 12 2021

justincady added a comment to D105218: [llvm-objcopy] Improve performance of long pattern lists.

I am not @bcain, but I tested this patch locally and can confirm it addressed the performance issue (of using a large list of symbols) for me.

Jul 12 2021, 7:44 AM · Restricted Project

Aug 27 2020

justincady added a comment to D86471: [MSAN] Add fiber switching APIs.

@vitalybuka Thanks for the review. I updated the diff with your recommended changes for the unit tests.

Aug 27 2020, 4:44 PM · Restricted Project
justincady updated the diff for D86471: [MSAN] Add fiber switching APIs.

Remove required test architectures from unit tests.

Aug 27 2020, 4:40 PM · Restricted Project
justincady updated the diff for D86471: [MSAN] Add fiber switching APIs.

Address outstanding comments. I have re-run all of the tests with the new changes.

Aug 27 2020, 8:31 AM · Restricted Project
justincady added inline comments to D86471: [MSAN] Add fiber switching APIs.
Aug 27 2020, 8:28 AM · Restricted Project

Aug 25 2020

justincady added inline comments to D86471: [MSAN] Add fiber switching APIs.
Aug 25 2020, 8:22 AM · Restricted Project

Aug 24 2020

justincady requested review of D86471: [MSAN] Add fiber switching APIs.
Aug 24 2020, 9:56 AM · Restricted Project