This is an archive of the discontinued LLVM Phabricator instance.

Differential D109183

[asan] Fixed link error by setting jump symbol to R_X86_64_PLT32.
ClosedPublic

Authored by kstoimenov on Sep 2 2021, 12:28 PM.

Details

Reviewers
vitalybuka
Commits
rGcf53c6c97106: [asan] Fixed link error by setting jump symbol to R_X86_64_PLT32.
Summary

Fixing this link error:
ld: error: relocation R_X86_64_PC32 cannot be used against symbol __asan_report_load...; recompile with -fPIC

Diff Detail

Event Timeline

kstoimenov created this revision.Sep 2 2021, 12:28 PM
Herald added subscribers: pengfei, hiraditya. · View Herald TranscriptSep 2 2021, 12:28 PM
kstoimenov requested review of this revision.Sep 2 2021, 12:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2021, 12:28 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B122368: Diff 370363.Sep 2 2021, 12:59 PM
vitalybuka accepted this revision.Sep 2 2021, 1:08 PM

It should be visible in test? Can you please update one?

This revision is now accepted and ready to land.Sep 2 2021, 1:08 PM
kstoimenov updated this revision to Diff 370413.Sep 2 2021, 2:33 PM

Added tests.

kstoimenov updated this revision to Diff 370418.Sep 2 2021, 2:49 PM

Fixed a test.

This revision was landed with ongoing or failed builds.Sep 2 2021, 2:51 PM
Closed by commit rGcf53c6c97106: [asan] Fixed link error by setting jump symbol to R_X86_64_PLT32. (authored by kstoimenov). · Explain Why
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rGcf53c6c97106: [asan] Fixed link error by setting jump symbol to R_X86_64_PLT32..
Harbormaster completed remote builds in B122404: Diff 370418.Sep 2 2021, 3:29 PM

Revision Contents

PathSize
llvm/
lib/
Target/
X86/
3 lines

Diff 370363

llvm/lib/Target/X86/X86MCInstLower.cpp

Show First 20 Lines • Show All 1,520 Lines • ▼ Show 20 Linesvoid X86AsmPrinter::emitAsanReportError(Module &M, unsigned Reg,
MCSymbol *ReportError = OutContext.getOrCreateSymbol( MCSymbol *ReportError = OutContext.getOrCreateSymbol(
"__asan_report_" + Name + utostr(1ULL << AccessInfo.AccessSizeIndex)); "__asan_report_" + Name + utostr(1ULL << AccessInfo.AccessSizeIndex));
OutStreamer->emitInstruction(MCInstBuilder(X86::MOV64rr) OutStreamer->emitInstruction(MCInstBuilder(X86::MOV64rr)
.addReg(X86::RDI) .addReg(X86::RDI)
.addReg(X86::NoRegister + Reg), .addReg(X86::NoRegister + Reg),
STI); STI);
OutStreamer->emitInstruction( OutStreamer->emitInstruction(
MCInstBuilder(X86::JMP_1) MCInstBuilder(X86::JMP_1)
.addExpr(MCSymbolRefExpr::create(ReportError, OutContext)), .addExpr(MCSymbolRefExpr::create(ReportError, MCSymbolRefExpr::VK_PLT,
OutContext)),
STI); STI);
} }
void X86AsmPrinter::emitAsanMemaccessSymbols(Module &M) { void X86AsmPrinter::emitAsanMemaccessSymbols(Module &M) {
if (AsanMemaccessSymbols.empty()) if (AsanMemaccessSymbols.empty())
return; return;
const Triple &TT = TM.getTargetTriple(); const Triple &TT = TM.getTargetTriple();
▲ Show 20 Lines • Show All 1,337 Lines • Show Last 20 Lines