Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D109007

[libomptarget] Move HostDataToTargetTy states into StatesTy
ClosedPublic
Actions

Authored by ye-luo on Aug 31 2021, 10:57 AM.

Details

Reviewers
tianshilei1992
grokos
jdoerfert
Commits
rG289a1089cd1f: [libomptarget] Move HostDataToTargetTy states into StatesTy
Summary

Use unique_ptr to achieve the effect of mutable.

Remove mutable keyword of DynRefCount and HoldRefCount
Remove std::shared_ptr from UpdateMtx

Diff Detail

Event Timeline

ye-luo requested review of this revision.Aug 31 2021, 10:57 AM
ye-luo created this revision.
Harbormaster completed remote builds in B121959: Diff 369736.Aug 31 2021, 11:29 AM
tianshilei1992 accepted this revision.Aug 31 2021, 11:56 AM

LGTM. Thanks for the clean up.

This revision is now accepted and ready to land.Aug 31 2021, 11:56 AM
grokos added a subscriber: grokos.Aug 31 2021, 12:06 PM
grokos added inline comments.
openmp/libomptarget/src/device.h
63

Outdated comment, RefCount is no longer mutable.

ye-luo updated this revision to Diff 369763.Aug 31 2021, 12:34 PM
ye-luo marked an inline comment as done.
ye-luo added inline comments.
openmp/libomptarget/src/device.h
63

Good catch. Updated.

grokos accepted this revision.Aug 31 2021, 12:41 PM
Harbormaster completed remote builds in B121974: Diff 369763.Aug 31 2021, 1:09 PM
ye-luo updated this revision to Diff 370156.Sep 1 2021, 9:34 PM
ye-luo marked an inline comment as done.
ye-luo edited the summary of this revision. (Show Details)
Herald added a reviewer: jdoerfert. · View Herald TranscriptSep 1 2021, 9:34 PM
Herald added a subscriber: sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B122236: Diff 370156.Sep 1 2021, 9:35 PM
This revision was landed with ongoing or failed builds.Sep 1 2021, 9:49 PM
Closed by commit rG289a1089cd1f: [libomptarget] Move HostDataToTargetTy states into StatesTy (authored by ye-luo). · Explain Why
This revision was automatically updated to reflect the committed changes.
ye-luo added a commit: rG289a1089cd1f: [libomptarget] Move HostDataToTargetTy states into StatesTy.
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2021, 9:49 PM
devnexen added a subscriber: devnexen.Sep 3 2021, 10:00 PM

Devicety assignment operator now fails to compile due to HostDataToTargetTy members constified (clang/libc++)

ye-luo added a comment.Sep 4 2021, 11:51 AM
In D109007#2983426, @devnexen wrote:

Devicety assignment operator now fails to compile due to HostDataToTargetTy members constified (clang/libc++)

D109276 should solve this issue.

Revision Contents
Changeset List

PathSize
openmp/
libomptarget/
src/
133 lines

Diff 370157

View Options

openmp/libomptarget/src/device.h

Loading...