Page MenuHomePhabricator

[libomptarget] Move HostDataToTargetTy states into StatesTy
ClosedPublic

Authored by ye-luo on Aug 31 2021, 10:57 AM.

Details

Summary

Use unique_ptr to achieve the effect of mutable.

Remove mutable keyword of DynRefCount and HoldRefCount
Remove std::shared_ptr from UpdateMtx

Diff Detail

Event Timeline

ye-luo requested review of this revision.Aug 31 2021, 10:57 AM
ye-luo created this revision.
tianshilei1992 accepted this revision.Aug 31 2021, 11:56 AM

LGTM. Thanks for the clean up.

This revision is now accepted and ready to land.Aug 31 2021, 11:56 AM
grokos added a subscriber: grokos.Aug 31 2021, 12:06 PM
grokos added inline comments.
openmp/libomptarget/src/device.h
63

Outdated comment, RefCount is no longer mutable.

ye-luo updated this revision to Diff 369763.Aug 31 2021, 12:34 PM
ye-luo marked an inline comment as done.
ye-luo added inline comments.
openmp/libomptarget/src/device.h
63

Good catch. Updated.

grokos accepted this revision.Aug 31 2021, 12:41 PM
ye-luo updated this revision to Diff 370156.Sep 1 2021, 9:34 PM
ye-luo marked an inline comment as done.
ye-luo edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Sep 1 2021, 9:49 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2021, 9:49 PM

Devicety assignment operator now fails to compile due to HostDataToTargetTy members constified (clang/libc++)

Devicety assignment operator now fails to compile due to HostDataToTargetTy members constified (clang/libc++)

D109276 should solve this issue.