This is an archive of the discontinued LLVM Phabricator instance.

Differential D108946

Fix dbg-distring-uint.ll test failure on platforms not supporting x86 target
ClosedPublic

Authored by cchen15 on Aug 30 2021, 1:45 PM.

Details

Reviewers
aprantl
lebedev.ri
Summary

Moved the test to CodeGen/X86 to prevent it from running everywhere.

Diff Detail

Event Timeline

cchen15 requested review of this revision.Aug 30 2021, 1:45 PM
cchen15 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2021, 1:45 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B121813: Diff 369542.Aug 30 2021, 1:47 PM
cchen15 added a comment.Aug 30 2021, 1:48 PM

I can't find documentation on the REQUIRES keyword. A quick grep shows that x86-registered-target seems to be the one to use (I tried x86_64-registered-target but that's reported as UNSUPPORTED). Please suggest a better requirement if there's one.

lebedev.ri added a subscriber: lebedev.ri.Aug 30 2021, 1:50 PM
lebedev.ri added inline comments.
llvm/test/CodeGen/Generic/dbg-distringtype-uint.ll
49

Shouldn't this test simply be moved info llvm/test/CodeGen/X86/ ?

cchen15 updated this revision to Diff 369548.Aug 30 2021, 2:14 PM
cchen15 edited the summary of this revision. (Show Details)

Moved the test to CodeGen/X86.

Herald added a subscriber: pengfei. · View Herald TranscriptAug 30 2021, 2:14 PM
cchen15 added a reviewer: lebedev.ri.Aug 30 2021, 2:18 PM

Thanks for the suggestion, @lebedev.ri. Could you please approve if this looks good to you?

Harbormaster completed remote builds in B121818: Diff 369548.Aug 30 2021, 3:10 PM
aprantl accepted this revision.Aug 31 2021, 11:25 AM
This revision is now accepted and ready to land.Aug 31 2021, 11:25 AM
cchen15 closed this revision.Aug 31 2021, 12:02 PM

Closed by commit rG1d36988394a5f37: Moved the test to X86 as it's x86 specific. (authored by cchen15).

cchen15 mentioned this in D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType.Sep 7 2021, 3:53 AM

Revision Contents

PathSize
llvm/
test/
CodeGen/
Generic/
1 line

Diff 369542

llvm/test/CodeGen/Generic/dbg-distringtype-uint.ll

; REQUIRES: x86-registered-target
; RUN: llc -filetype=obj < %s | llvm-dwarfdump -debug-info - | FileCheck %s ; RUN: llc -filetype=obj < %s | llvm-dwarfdump -debug-info - | FileCheck %s
; ;
; CHECK: [[SYM:[a-z0-9]+]]: DW_TAG_formal_parameter ; CHECK: [[SYM:[a-z0-9]+]]: DW_TAG_formal_parameter
; CHECK: DW_AT_name ("esym") ; CHECK: DW_AT_name ("esym")
; CHECK: DW_AT_type ([[TYPE:[a-z0-9]+]] "CHARACTER_1") ; CHECK: DW_AT_type ([[TYPE:[a-z0-9]+]] "CHARACTER_1")
; ;
; CHECK: DW_TAG_formal_parameter ; CHECK: DW_TAG_formal_parameter
; CHECK: DW_AT_const_value (7523094288207667809) ; CHECK: DW_AT_const_value (7523094288207667809)
Show All 31 Lines
; end module ; end module
; ;
; The optimizations encode the constant string as an i64 constant in ; The optimizations encode the constant string as an i64 constant in
; the debug info for esym, the return variable of the function esym. ; the debug info for esym, the return variable of the function esym.
; ;
; ModuleID = 'se6.bc' ; ModuleID = 'se6.bc'
source_filename = "se6.f90" source_filename = "se6.f90"
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
lebedev.riUnsubmitted
Not Done
ReplyInline Actions

Shouldn't this test simply be moved info llvm/test/CodeGen/X86/ ?

lebedev.ri: Shouldn't this test simply be moved info `llvm/test/CodeGen/X86/` ?
@"semiempirical_corrections_mp_esym_$ELEMNT" = internal unnamed_addr constant [1 x [8 x i8]] [[8 x i8] c"abcdefgh"], align 8, !dbg !0 @"semiempirical_corrections_mp_esym_$ELEMNT" = internal unnamed_addr constant [1 x [8 x i8]] [[8 x i8] c"abcdefgh"], align 8, !dbg !0
; Function Attrs: nofree nounwind uwtable ; Function Attrs: nofree nounwind uwtable
define void @semiempirical_corrections_mp_gcpcor_() local_unnamed_addr #1 !dbg !22 { define void @semiempirical_corrections_mp_gcpcor_() local_unnamed_addr #1 !dbg !22 {
alloca_1: alloca_1:
%"var$47" = alloca i64, align 8, !dbg !34 %"var$47" = alloca i64, align 8, !dbg !34
call void @llvm.dbg.value(metadata i64 7523094288207667809, metadata !12, metadata !DIExpression()), !dbg !40 call void @llvm.dbg.value(metadata i64 7523094288207667809, metadata !12, metadata !DIExpression()), !dbg !40
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines