This is an archive of the discontinued LLVM Phabricator instance.

Differential D108946

Fix dbg-distring-uint.ll test failure on platforms not supporting x86 target
ClosedPublic

Authored by cchen15 on Aug 30 2021, 1:45 PM.

Details

Reviewers
aprantl
lebedev.ri
Summary

Moved the test to CodeGen/X86 to prevent it from running everywhere.

Diff Detail

Event Timeline

cchen15 requested review of this revision.Aug 30 2021, 1:45 PM
cchen15 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2021, 1:45 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B121813: Diff 369542.Aug 30 2021, 1:47 PM
cchen15 added a comment.Aug 30 2021, 1:48 PM

I can't find documentation on the REQUIRES keyword. A quick grep shows that x86-registered-target seems to be the one to use (I tried x86_64-registered-target but that's reported as UNSUPPORTED). Please suggest a better requirement if there's one.

lebedev.ri added a subscriber: lebedev.ri.Aug 30 2021, 1:50 PM
lebedev.ri added inline comments.
llvm/test/CodeGen/Generic/dbg-distringtype-uint.ll
49

Shouldn't this test simply be moved info llvm/test/CodeGen/X86/ ?

cchen15 updated this revision to Diff 369548.Aug 30 2021, 2:14 PM
cchen15 edited the summary of this revision. (Show Details)

Moved the test to CodeGen/X86.

Herald added a subscriber: pengfei. · View Herald TranscriptAug 30 2021, 2:14 PM
cchen15 added a reviewer: lebedev.ri.Aug 30 2021, 2:18 PM

Thanks for the suggestion, @lebedev.ri. Could you please approve if this looks good to you?

Harbormaster completed remote builds in B121818: Diff 369548.Aug 30 2021, 3:10 PM
aprantl accepted this revision.Aug 31 2021, 11:25 AM
This revision is now accepted and ready to land.Aug 31 2021, 11:25 AM
cchen15 closed this revision.Aug 31 2021, 12:02 PM

Closed by commit rG1d36988394a5f37: Moved the test to X86 as it's x86 specific. (authored by cchen15).

cchen15 mentioned this in D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType.Sep 7 2021, 3:53 AM

Revision Contents

PathSize
llvm/
test/
CodeGen/
Generic/
X86/
Generic/

Diff 369548

llvm/test/CodeGen/Generic/dbg-distringtype-uint.ll

  • This file was moved to llvm/test/CodeGen/X86/dbg-distringtype-uint.ll.

llvm/test/CodeGen/X86/dbg-distringtype-uint.ll

  • This file was moved from llvm/test/CodeGen/Generic/dbg-distringtype-uint.ll.