Page MenuHomePhabricator

[LLDB][GUI] Add source file searcher
AcceptedPublic

Authored by OmarEmaraDev on Aug 30 2021, 1:26 PM.

Details

Summary

This patch adds a new searcher to find source files and a new shortcut
to the sources window (F) that changes the displayed file to the one
selected in the searcher dialog. The added searcher displays the
smallest unique path that identifies the file for a more compact and
friendly representation.

This patch is not sufficient for the workflow outlined, because the
sources window was not made for that purpose and would need refactoring
to support arbitrary files that are independent of a symbol context. An
attempt at refactoring proved a bit involved, so it will be done later
in a separate patch.

Diff Detail

Event Timeline

OmarEmaraDev created this revision.Aug 30 2021, 1:26 PM
OmarEmaraDev requested review of this revision.Aug 30 2021, 1:26 PM
Herald added a project: Restricted Project. · View Herald Transcript

An example typical workflow for navigating to a file and adding a breakpoint.

@clayborg Did you take a look at this?

clayborg accepted this revision.Sep 7 2021, 2:57 PM

Sorry for the delay, yes this looks good.

This revision is now accepted and ready to land.Sep 7 2021, 2:57 PM