Page MenuHomePhabricator

OmarEmaraDev (Omar Emara)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2021, 7:57 AM (15 w, 5 d)

Recent Activity

Today

OmarEmaraDev added a comment to D106999: [LLDB][GUI] Add Environment Variable Field.

Example list of environment fields:

Wed, Jul 28, 1:22 PM · Restricted Project
OmarEmaraDev requested review of D106999: [LLDB][GUI] Add Environment Variable Field.
Wed, Jul 28, 1:21 PM · Restricted Project
OmarEmaraDev updated the diff for D106192: [LLDB][GUI] Add Create Target form.
  • Address review comments
Wed, Jul 28, 10:44 AM · Restricted Project

Yesterday

OmarEmaraDev added a comment to D106192: [LLDB][GUI] Add Create Target form.

I still can't get remote debugging to work unfortunately, or maybe I don't understand it really. The way I understand it is as follows:

Tue, Jul 27, 2:39 PM · Restricted Project
OmarEmaraDev updated the diff for D106192: [LLDB][GUI] Add Create Target form.
  • Rebase on main.
  • Add basic remote debugging support.
Tue, Jul 27, 2:38 PM · Restricted Project
OmarEmaraDev added a comment to D106873: [lldb] Bump the amount of characters printed on pexpect failures from 100 to 2000.

Note that all the GUI tests spawn a terminal of dimensions (100, 500), not the default (24,80). And I am guessing this includes the control characters as well. So even 2000 may not be enough even.

Tue, Jul 27, 8:22 AM · Restricted Project

Mon, Jul 26

OmarEmaraDev added a comment to D106553: [LLDB][GUI] Resolve paths in file/directory fields.

@clayborg Did you check D106564? This is the last patch needed to do the rebase.

Mon, Jul 26, 12:07 PM · Restricted Project

Sat, Jul 24

OmarEmaraDev added inline comments to D106553: [LLDB][GUI] Resolve paths in file/directory fields.
Sat, Jul 24, 12:41 AM · Restricted Project

Thu, Jul 22

OmarEmaraDev requested review of D106564: [LLDB][GUI] Add Arch Field.
Thu, Jul 22, 8:29 AM · Restricted Project
OmarEmaraDev requested review of D106553: [LLDB][GUI] Resolve paths in file/directory fields.
Thu, Jul 22, 8:09 AM · Restricted Project
OmarEmaraDev updated the diff for D106459: [LLDB][GUI] Check fields validity in actions.
  • Merge main and fix conflicts.
Thu, Jul 22, 5:33 AM · Restricted Project
OmarEmaraDev updated the diff for D106483: [LLDB][GUI] Add Platform Plugin Field.
  • Rebase on main and fix conflicts.
Thu, Jul 22, 4:45 AM · Restricted Project

Wed, Jul 21

OmarEmaraDev updated the diff for D106458: [LLDB][GUI] Add required property to text fields.
  • Remove default arguments
Wed, Jul 21, 1:10 PM · Restricted Project
OmarEmaraDev added a comment to D106192: [LLDB][GUI] Add Create Target form.

Are you going to land the other smaller diffs first and then update this one after hey have landed?

Wed, Jul 21, 12:57 PM · Restricted Project
OmarEmaraDev requested review of D106483: [LLDB][GUI] Add Platform Plugin Field.
Wed, Jul 21, 12:54 PM · Restricted Project
OmarEmaraDev requested review of D106467: [LLDB][GUI] Add Process Plugin Field.
Wed, Jul 21, 11:02 AM · Restricted Project
OmarEmaraDev added a comment to D106192: [LLDB][GUI] Add Create Target form.

Thanks @DavidSpickett! I will look into this and let you know how it goes.

Wed, Jul 21, 10:37 AM · Restricted Project
OmarEmaraDev added a comment to D106192: [LLDB][GUI] Add Create Target form.

I am currently breaking this patch into smaller independent viable patches as suggested.

Wed, Jul 21, 10:36 AM · Restricted Project
OmarEmaraDev requested review of D106459: [LLDB][GUI] Check fields validity in actions.
Wed, Jul 21, 10:01 AM · Restricted Project
OmarEmaraDev requested review of D106458: [LLDB][GUI] Add required property to text fields.
Wed, Jul 21, 10:00 AM · Restricted Project

Fri, Jul 16

OmarEmaraDev added a comment to D106192: [LLDB][GUI] Add Create Target form.

This doesn't support remote files yet, I am still having trouble testing those. Also, there is also an unrelated clang-format change, not sure if I should revert it or keep it.

Fri, Jul 16, 2:24 PM · Restricted Project
OmarEmaraDev requested review of D106192: [LLDB][GUI] Add Create Target form.
Fri, Jul 16, 2:21 PM · Restricted Project

Wed, Jul 14

OmarEmaraDev added inline comments to D105655: [LLDB][GUI] Add Process Attach form.
Wed, Jul 14, 3:23 PM · Restricted Project
OmarEmaraDev updated the diff for D105655: [LLDB][GUI] Add Process Attach form.
  • Manually continue if needed.
Wed, Jul 14, 3:23 PM · Restricted Project

Tue, Jul 13

OmarEmaraDev added a comment to D105655: [LLDB][GUI] Add Process Attach form.

Two actions with an option:

Tue, Jul 13, 12:55 PM · Restricted Project
OmarEmaraDev updated the diff for D105655: [LLDB][GUI] Add Process Attach form.
  • Return raw pointers instead of unique ones.
  • Add Show Advance Settings option.
  • Allow detaching and killing at the same time.
  • Allow detaching while keeping process stopped.
  • Handle review comments.
Tue, Jul 13, 12:54 PM · Restricted Project
OmarEmaraDev added a comment to D105655: [LLDB][GUI] Add Process Attach form.

Updated UI:

Tue, Jul 13, 8:09 AM · Restricted Project
OmarEmaraDev updated the diff for D105655: [LLDB][GUI] Add Process Attach form.
  • Add kill/detach form.
  • Fix forms with no fields.
Tue, Jul 13, 8:04 AM · Restricted Project
OmarEmaraDev planned changes to D105655: [LLDB][GUI] Add Process Attach form.

Currently working on the detach/kill form.

Tue, Jul 13, 4:09 AM · Restricted Project
OmarEmaraDev updated the diff for D105655: [LLDB][GUI] Add Process Attach form.
  • Use unique pointers for field delegates.
  • Fix typos in Select methods.
  • Set the process name to the main executable name by default.
  • Turn plugin name into a choice field.
  • Update debugger target if a new one was created.
  • Remove superfluous continue operation.
Tue, Jul 13, 4:07 AM · Restricted Project

Thu, Jul 8

OmarEmaraDev added a comment to D105655: [LLDB][GUI] Add Process Attach form.

I initially created two forms for attach by name and attach by PID, because the options were divided between them. Today I tried to reimplement that such that it is a single form with a choices field at the top that determines if it is by name or PID. The fields are then shown or hidden based on that enum. Additionally, other fields can control the visibility of other fields, for instance, the "Include existing processes" field. I think it works fine and the UX looks good. Here is an example, what do you think?

Thu, Jul 8, 1:45 PM · Restricted Project
OmarEmaraDev requested review of D105655: [LLDB][GUI] Add Process Attach form.
Thu, Jul 8, 1:32 PM · Restricted Project

Fri, Jul 2

OmarEmaraDev updated the summary of D104395: [LLDB][GUI] Add initial forms support.
Fri, Jul 2, 7:32 AM · Restricted Project

Wed, Jun 30

OmarEmaraDev requested review of D104395: [LLDB][GUI] Add initial forms support.
Wed, Jun 30, 1:13 PM · Restricted Project
OmarEmaraDev added a comment to D104395: [LLDB][GUI] Add initial forms support.

Full example:

Wed, Jun 30, 1:12 PM · Restricted Project
OmarEmaraDev updated the diff for D104395: [LLDB][GUI] Add initial forms support.
  • Add contextual scrolling support.
Wed, Jun 30, 1:07 PM · Restricted Project

Tue, Jun 29

OmarEmaraDev planned changes to D104395: [LLDB][GUI] Add initial forms support.
  • Scrolling was temporarily removed from the patch. It was causing issues with fields that change in size. I will reimplement it as contextual scrolling directly.
  • Action buttons weren't moved to the window border as discussed. The window border is already highlighted when the form is active, which makes highlighting and navigating fields not user friendly. Action buttons are now scrollable though, which solves the issue of space.
Tue, Jun 29, 2:18 PM · Restricted Project
OmarEmaraDev updated the diff for D104395: [LLDB][GUI] Add initial forms support.
  • Rewrite internal field navigation.
  • Rewrite form window drawing. Form delegate no longer have drawing routines.
  • Add global error messages.
  • Add action bar. Form delegate can now define as many arbitrary actions as needed.
  • Make action button scrollable.
  • Add support for composite fields.
  • Add backward tab navigation.
Tue, Jun 29, 2:12 PM · Restricted Project

Jun 24 2021

OmarEmaraDev planned changes to D104395: [LLDB][GUI] Add initial forms support.

Not available in this patch yet:

  • Global error messages.
  • Contextual scrolling.
  • Action bar.
  • Auto completion.
Jun 24 2021, 2:47 PM · Restricted Project
OmarEmaraDev updated the diff for D104395: [LLDB][GUI] Add initial forms support.
  • Add Surface type.
  • Add Pad and SubPad types.
  • Implement dynamic scrolling.
  • Implement per-field validation and error messages.
  • Implement File field.
  • Implement Directory field.
  • Implement List field.
  • Refactor field drawing.
Jun 24 2021, 2:43 PM · Restricted Project

Jun 23 2021

OmarEmaraDev added a comment to D104395: [LLDB][GUI] Add initial forms support.

Since we are still working on this diff. I will add the other form functionality I have been working on here as well if you don't mind.

Jun 23 2021, 11:21 AM · Restricted Project

Jun 22 2021

OmarEmaraDev updated the diff for D104395: [LLDB][GUI] Add initial forms support.
  • Remove Field type and use FieldDelegate directly
Jun 22 2021, 2:02 PM · Restricted Project

Jun 18 2021

OmarEmaraDev added a comment to D104395: [LLDB][GUI] Add initial forms support.

@clayborg I tried implementing scrolling mechanisms as suggested. My first trial essentially defined a "visible area" rectangle which gets updated with every time the selection changes, then when it comes to drawing, each field checks if it is completely contained in the visible area and draws itself with an offset that we get from from the visible area origin. This worked, but fields that spans multiple columns can completely disappear leaving mostly no fields on the window, so it worked in most cases, but not all. My second trial was about drawing to an ncurses pad that is large enough to fit all contents, then the window is refreshed from that pad. This used manual ncurses calls because we don't support pads at the moment, so I scratched that for now. I think support for pads would be good for those kind of applications in the future. I plan to work on a proposal that would include support for pads and lightweight subwindows, I will detail that later.

Jun 18 2021, 1:42 PM · Restricted Project
OmarEmaraDev updated the diff for D104395: [LLDB][GUI] Add initial forms support.
  • Add form pages.
  • Handle review.
Jun 18 2021, 1:27 PM · Restricted Project

Jun 17 2021

OmarEmaraDev updated the diff for D104395: [LLDB][GUI] Add initial forms support.
  • Always scroll left on removing a character
Jun 17 2021, 10:11 AM · Restricted Project
OmarEmaraDev added inline comments to D104395: [LLDB][GUI] Add initial forms support.
Jun 17 2021, 9:31 AM · Restricted Project
OmarEmaraDev updated the diff for D104395: [LLDB][GUI] Add initial forms support.
  • Remove PutCStringTruncatedWidth, use a character limit instead.
  • Handle review.
Jun 17 2021, 9:29 AM · Restricted Project
OmarEmaraDev added a comment to D104395: [LLDB][GUI] Add initial forms support.

did you consider implementing each field as a Window?

Jun 17 2021, 4:14 AM · Restricted Project

Jun 16 2021

OmarEmaraDev added a comment to D104395: [LLDB][GUI] Add initial forms support.

An example form:

Jun 16 2021, 9:21 AM · Restricted Project
OmarEmaraDev requested review of D104395: [LLDB][GUI] Add initial forms support.
Jun 16 2021, 9:13 AM · Restricted Project

Jun 11 2021

OmarEmaraDev updated the diff for D100243: [LLDB][GUI] Expand selected thread tree item by default.
  • Handle review
Jun 11 2021, 1:28 PM · Restricted Project

Jun 10 2021

OmarEmaraDev added inline comments to D100243: [LLDB][GUI] Expand selected thread tree item by default.
Jun 10 2021, 2:25 PM · Restricted Project
OmarEmaraDev updated the diff for D100243: [LLDB][GUI] Expand selected thread tree item by default.
  • Merge branch 'main' into lldb-gui-expand-threads-tree
  • Implement default selection
Jun 10 2021, 2:23 PM · Restricted Project

Apr 20 2021

OmarEmaraDev added inline comments to D100243: [LLDB][GUI] Expand selected thread tree item by default.
Apr 20 2021, 6:43 AM · Restricted Project
OmarEmaraDev updated the diff for D100243: [LLDB][GUI] Expand selected thread tree item by default.
  • Follow LLVM coding guidelines
Apr 20 2021, 6:25 AM · Restricted Project

Apr 10 2021

OmarEmaraDev requested review of D100243: [LLDB][GUI] Expand selected thread tree item by default.
Apr 10 2021, 4:00 AM · Restricted Project