Page MenuHomePhabricator

[CMake] Disable -Wmisleading-indentation when using gcc
Needs ReviewPublic

Authored by vabridgers on Aug 28 2021, 3:56 AM.

Details

Reviewers
MaskRay
Summary

gcc doesn't handle -Wmisleading-indentation correctly, leading to
warnings when using gcc. See
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81334 for details. This
change disables -Wmisleading-indentation to avoid warnings when using
gcc, and leaves it enabled for other compilers. This can be re-enabled
when gcc behaves as expected.

Diff Detail

Event Timeline

vabridgers created this revision.Aug 28 2021, 3:56 AM
vabridgers requested review of this revision.Aug 28 2021, 3:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2021, 3:56 AM

Consider using CHECK_CXX_SOURCE_COMPILES to check the GCC issue.
Also, please add a gcc.gnu.org/PRxxx comment.