[X86] Remove X86LowerAMXType::getRowFromCol from X86LowerAMXType.cpp

[vabridgers]

Summary

Remove method X86LowerAMXType::getRowFromCol since it's not used, and
it's causing a warning.

[AMDGPU] Fix gcc 9.3.0 warning from -Wtype-limits

Fixes this warning when using gcc 9.3.0

lib/Target/AMDGPU/R600GenSubtargetInfo.inc:282:62: warning: comparison
of unsigned expression < 0 is always false [-Wtype-limits]
if (Bits[R600::FeatureLocalMemorySize0] && LocalMemorySize <0)

LocalMemorySize = 0;

[CMake] Disable -Wmisleading-indentation when using gcc

gcc doesn't handle -Wmisleading-indentation correctly, leading to
warnings when using gcc. See
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81334 for details. This
change disables -Wmisleading-indentation to avoid warnings when using
gcc, and leaves it enabled for other compilers. This can be re-enabled
when gcc behaves as expected.

[AMDGPU] Use gcc pragmas to disable -Wtype-limits warning

Use gcc pragmas to disable warning in generated filed. This is producing
a warning when using using gcc 9.3.0.

lib/Target/AMDGPU/R600GenSubtargetInfo.inc:282:62: warning: comparison
of unsigned expression < 0 is always false [-Wtype-limits]

if (Bits[R600::FeatureLocalMemorySize0] && LocalMemorySize <0)
   LocalMemorySize = 0;

[vabridgers]

Argggg. Didn't meant to submit all 4 of these very minor changes in a single review. I'll abandon and resubmit as separate reviews.

llvm/cmake/modules/HandleLLVMOptions.cmake

if (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))
   if (NOT C_WCOMMENT_ALLOWS_LINE_WRAP)
     append("-Wno-comment" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
   endif()
 
   # Enable -Wstring-conversion to catch misuse of string literals.
   add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG)
 
   # Prevent bugs that can happen with llvm's brace style.
+  if (CMAKE_COMPILER_IS_GNUCXX)
+    add_flag_if_supported("-Wno-misleading-indentation" MISLEADING_INDENTATION_FLAG)
+  else()
     add_flag_if_supported("-Wmisleading-indentation" MISLEADING_INDENTATION_FLAG)
+  endif()
 endif (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))
 
 if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND NOT LLVM_ENABLE_WARNINGS)
   append("-w" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
 endif()
 
 macro(append_common_sanitizer_flags)
   if (NOT MSVC)

llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp

 //===-- AMDGPUSubtarget.cpp - AMDGPU Subtarget Information ----------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //

 
 using namespace llvm;
 
 #define DEBUG_TYPE "amdgpu-subtarget"
 
 #define GET_SUBTARGETINFO_TARGET_DESC
 #define GET_SUBTARGETINFO_CTOR
 #define AMDGPUSubtarget GCNSubtarget
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wtype-limits"
 #include "AMDGPUGenSubtargetInfo.inc"
+#pragma GCC diagnostic pop
 #undef AMDGPUSubtarget
 
 static cl::opt<bool> DisablePowerSched(
   "amdgpu-disable-power-sched",
   cl::desc("Disable scheduling to minimize mAI power bursts"),
   cl::init(false));
 
 static cl::opt<bool> EnableVGPRIndexMode(

llvm/lib/Target/AMDGPU/R600Subtarget.cpp

 //===-- R600Subtarget.cpp - R600 Subtarget Information --------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 /// \file
 /// Implements the R600 specific subclass of TargetSubtarget.
 //
 //===----------------------------------------------------------------------===//
 
 #include "R600Subtarget.h"
 #include "MCTargetDesc/R600MCTargetDesc.h"
 
 using namespace llvm;
 
 #define DEBUG_TYPE "r600-subtarget"
 
 #define GET_SUBTARGETINFO_TARGET_DESC
 #define GET_SUBTARGETINFO_CTOR
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wtype-limits"
 #include "R600GenSubtargetInfo.inc"
+#pragma GCC diagnostic pop
 
 R600Subtarget::R600Subtarget(const Triple &TT, StringRef GPU, StringRef FS,
                              const TargetMachine &TM)
     : R600GenSubtargetInfo(TT, GPU, /*TuneCPU*/ GPU, FS), AMDGPUSubtarget(TT),
       InstrInfo(*this),
       FrameLowering(TargetFrameLowering::StackGrowsUp, getStackAlignment(), 0),
       FMA(false), CaymanISA(false), CFALUBug(false), HasVertexCache(false),
       R600ALUInst(false), FP64(false), TexVTXClauseSize(0), Gen(R600),

llvm/lib/Target/X86/X86LowerAMXType.cpp

 //===- Target/X86/X86LowerAMXType.cpp - -------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
class X86LowerAMXType {
   std::map<Value *, Value *> Col2Row;
 
 public:
   X86LowerAMXType(Function &F) : Func(F) {}
   bool visit();
   void combineLoadBitcast(LoadInst *LD, BitCastInst *Bitcast);
   void combineBitcastStore(BitCastInst *Bitcast, StoreInst *ST);
   bool transformBitcast(BitCastInst *Bitcast);
-  Value *getRowFromCol(Instruction *II, Value *V, unsigned Granularity);
 };
 
-Value *X86LowerAMXType::getRowFromCol(Instruction *II, Value *V,
-                                      unsigned Granularity) {
-  if (Col2Row.count(V))
-    return Col2Row[V];
-  IRBuilder<> Builder(&*II->getParent()->getFirstInsertionPt());
-  if (auto *I = dyn_cast<Instruction>(V)) {
-    BasicBlock::iterator Iter = I->getIterator();
-    ++Iter;
-    Builder.SetInsertPoint(&*Iter);
-  }
-  ConstantInt *Gran = Builder.getInt16(Granularity);
-  Value *RealRow = Builder.CreateUDiv(V, Gran);
-  Col2Row[V] = RealRow;
-  return RealRow;
-}
-
 // %src = load <256 x i32>, <256 x i32>* %addr, align 64
 // %2 = bitcast <256 x i32> %src to x86_amx
 // -->
 // %2 = call x86_amx @llvm.x86.tileloadd64.internal(i16 %row, i16 %col,
 // i8* %addr, i64 %stride64)
 void X86LowerAMXType::combineLoadBitcast(LoadInst *LD, BitCastInst *Bitcast) {
   Value *Row = nullptr, *Col = nullptr;
   Use &U = *(Bitcast->use_begin());