[flang] Apply double precision KindCode in specific proc interface

[jeanPerier]

Summary

The double precision KindCode was ignored when building the interface
of specific intrinsic procedures leading to bad semantics checks.

flang/lib/Evaluate/intrinsics.cpp

IntrinsicProcTable::Implementation::IsSpecificIntrinsicFunction(
   return std::nullopt;
 }
 
 DynamicType IntrinsicProcTable::Implementation::GetSpecificType(
     const TypePattern &pattern) const {
   const CategorySet &set{pattern.categorySet};
   CHECK(set.count() == 1);
   TypeCategory category{set.LeastElement().value()};
+  if (pattern.kindCode == KindCode::doublePrecision) {
+    return DynamicType{category, defaults_.doublePrecisionKind()};
+  } else {
     return DynamicType{category, defaults_.GetDefaultKind(category)};
   }
+}
 
 IntrinsicProcTable::~IntrinsicProcTable() = default;
 
 IntrinsicProcTable IntrinsicProcTable::Configure(
     const common::IntrinsicTypeDefaultKinds &defaults) {
   IntrinsicProcTable result;
   result.impl_ = std::make_unique<IntrinsicProcTable::Implementation>(defaults);
   return result;

flang/test/Semantics/call20.f90

+! RUN: %S/test_errors.sh %s %t %flang_fc1
+! REQUIRES: shell
+
+! Test that the interface of specific intrinsics passed as dummy arguments
+! are correctly validated against actual arguments explicit interface.
+
+  intrinsic :: abs, dabs
+  interface
+    subroutine foo(f)
+      interface
+        function f(x)
+          real :: f
+          real, intent(in) :: x
+        end function
+      end interface
+    end subroutine
+
+    subroutine foo2(f)
+      interface
+        function f(x)
+          double precision :: f
+          double precision, intent(in) :: x
+        end function
+      end interface
+    end subroutine
+  end interface
+
+  ! OK
+  call foo(abs)
+
+  ! OK
+  call foo2(dabs)
+
+  !ERROR: Actual procedure argument has interface incompatible with dummy argument 'f='
+  call foo(dabs)
+
+  !ERROR: Actual procedure argument has interface incompatible with dummy argument 'f='
+  call foo2(abs)
+end