This is an archive of the discontinued LLVM Phabricator instance.

Differential D108799

[lld/COFF] Ignore /LTCG and /LTCG:FOO flags
ClosedPublic

Authored by thakis on Aug 26 2021, 7:05 PM.

Details

Reviewers
aganea
Group Reviewers
lld
Commits
rG34ac7a7ac1a3: [lld/COFF] Ignore /LTCG, /LTCG:, /LTCGOUT:, /ILK: flags
Summary

We currently complain "could not open /LTCG: no such file or directory",
which isn't very useful. We could emit a warning when we see this flag, but
just ignoring it seems fine.

Final missing part of PR38799.

Diff Detail

Unit TestsFailed

TimeTest
110 msx64 debian > LLVM.CodeGen/AMDGPU::simple-indirect-call.ll
180 msx64 windows > LLVM.CodeGen/AMDGPU::simple-indirect-call.ll

Event Timeline

thakis created this revision.Aug 26 2021, 7:05 PM
Herald added a subscriber: dang. · View Herald TranscriptAug 26 2021, 7:05 PM
thakis requested review of this revision.Aug 26 2021, 7:05 PM
thakis added a parent revision: D108798: [lld/COFF] Use P_priv more.
Harbormaster completed remote builds in B121434: Diff 369019.Aug 26 2021, 7:43 PM
aganea accepted this revision.Aug 27 2021, 6:10 AM

Sounds good.

lld/COFF/Options.td
291

Can you add /ilk: and /ltcgout: as well? This otherwise causes issues after VS 2019 16.9

This revision is now accepted and ready to land.Aug 27 2021, 6:10 AM
aganea added inline comments.Aug 27 2021, 6:13 AM
lld/COFF/Options.td
291

Just to clarify: after VS 16.9, if these options aren't provided explicitly, the MSBuild property sheets would add these two options with default values.

thakis added inline comments.Aug 27 2021, 6:14 AM
lld/COFF/Options.td
291

Done, thanks :)

This revision was landed with ongoing or failed builds.Aug 27 2021, 6:16 AM
Closed by commit rG34ac7a7ac1a3: [lld/COFF] Ignore /LTCG, /LTCG:, /LTCGOUT:, /ILK: flags (authored by thakis). · Explain Why
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rG34ac7a7ac1a3: [lld/COFF] Ignore /LTCG, /LTCG:, /LTCGOUT:, /ILK: flags.
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2021, 6:16 AM

Revision Contents

PathSize
lld/
COFF/
2 lines

Diff 369019

lld/COFF/Options.td

Show First 20 Lines • Show All 273 Lines • ▼ Show 20 Lines
def show_timing : F<"time">; def show_timing : F<"time">;
def summary : F<"summary">; def summary : F<"summary">;
//============================================================================== //==============================================================================
// The flags below do nothing. They are defined only for link.exe compatibility. // The flags below do nothing. They are defined only for link.exe compatibility.
//============================================================================== //==============================================================================
def ignoreidl : F<"ignoreidl">; def ignoreidl : F<"ignoreidl">;
def ltcg : F<"ltcg">;
def nologo : F<"nologo">; def nologo : F<"nologo">;
def throwingnew : F<"throwingnew">; def throwingnew : F<"throwingnew">;
def editandcontinue : F<"editandcontinue">; def editandcontinue : F<"editandcontinue">;
def fastfail : F<"fastfail">; def fastfail : F<"fastfail">;
def delay : P_priv<"delay">; def delay : P_priv<"delay">;
def errorreport : P_priv<"errorreport">; def errorreport : P_priv<"errorreport">;
def idlout : P_priv<"idlout">; def idlout : P_priv<"idlout">;
def ltcg_opt : P_priv<"ltcg">;
aganeaUnsubmitted
Not Done
ReplyInline Actions

Can you add /ilk: and /ltcgout: as well? This otherwise causes issues after VS 2019 16.9

aganea: Can you add `/ilk:` and `/ltcgout:` as well? This otherwise causes issues after VS 2019 16.9
aganeaUnsubmitted
Not Done
ReplyInline Actions

Just to clarify: after VS 16.9, if these options aren't provided explicitly, the MSBuild property sheets would add these two options with default values.

aganea: Just to clarify: after VS 16.9, if these options aren't provided explicitly, the MSBuild…
thakisAuthorUnsubmitted
Done
ReplyInline Actions

Done, thanks :)

thakis: Done, thanks :)
def maxilksize : P_priv<"maxilksize">; def maxilksize : P_priv<"maxilksize">;
def tlbid : P_priv<"tlbid">; def tlbid : P_priv<"tlbid">;
def tlbout : P_priv<"tlbout">; def tlbout : P_priv<"tlbout">;
def verbose_all : P_priv<"verbose">; def verbose_all : P_priv<"verbose">;
def guardsym : P_priv<"guardsym">; def guardsym : P_priv<"guardsym">;