This is an archive of the discontinued LLVM Phabricator instance.

[lld/COFF] Ignore /LTCG and /LTCG:FOO flags
ClosedPublic

Authored by thakis on Aug 26 2021, 7:05 PM.

Details

Summary

We currently complain "could not open /LTCG: no such file or directory",
which isn't very useful. We could emit a warning when we see this flag, but
just ignoring it seems fine.

Final missing part of PR38799.

Diff Detail

Event Timeline

thakis created this revision.Aug 26 2021, 7:05 PM
thakis requested review of this revision.Aug 26 2021, 7:05 PM
aganea accepted this revision.Aug 27 2021, 6:10 AM

Sounds good.

lld/COFF/Options.td
291

Can you add /ilk: and /ltcgout: as well? This otherwise causes issues after VS 2019 16.9

This revision is now accepted and ready to land.Aug 27 2021, 6:10 AM
aganea added inline comments.Aug 27 2021, 6:13 AM
lld/COFF/Options.td
291

Just to clarify: after VS 16.9, if these options aren't provided explicitly, the MSBuild property sheets would add these two options with default values.

thakis added inline comments.Aug 27 2021, 6:14 AM
lld/COFF/Options.td
291

Done, thanks :)

This revision was landed with ongoing or failed builds.Aug 27 2021, 6:16 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2021, 6:16 AM