Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D108781

[lld-macho] Have -ObjC load archive members before symbol resolution
ClosedPublic
Actions

Authored by int3 on Aug 26 2021, 12:12 PM.

Details

Reviewers
gkm
oontvoo
Group Reviewers
Restricted Project
Commits
rG9b5148d4262d: [lld-macho] Have -ObjC load archive members before symbol resolution
Summary

This is what ld64 does. Deviating in behavior here can result
in some subtle duplicate symbol errors, as detailed in the objc.s test.

Fixes PR51475.

Diff Detail

Event Timeline

int3 created this revision.Aug 26 2021, 12:12 PM
Herald added a reviewer: gkm. · View Herald TranscriptAug 26 2021, 12:12 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: ormris, steven_wu, hiraditya. · View Herald Transcript
int3 requested review of this revision.Aug 26 2021, 12:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2021, 12:12 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B121390: Diff 368955.Aug 26 2021, 12:13 PM
int3 edited the summary of this revision. (Show Details)Aug 26 2021, 12:17 PM
oontvoo accepted this revision.Aug 26 2021, 1:20 PM
oontvoo added a subscriber: oontvoo.

LGTM - thanks!

This revision is now accepted and ready to land.Aug 26 2021, 1:20 PM
This revision was landed with ongoing or failed builds.Aug 26 2021, 3:57 PM
Closed by commit rG9b5148d4262d: [lld-macho] Have -ObjC load archive members before symbol resolution (authored by int3). · Explain Why
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rG9b5148d4262d: [lld-macho] Have -ObjC load archive members before symbol resolution.
int3 mentioned this in D116913: [lld-macho] Add --start-lib --end-lib.Jan 17 2022, 10:47 PM

Revision Contents
Changeset List

PathSize
lld/
MachO/
3 lines
test/
MachO/
2 lines
70 lines

Diff 369000

View Options

lld/MachO/Driver.cpp

Loading...
View Options

lld/test/MachO/lto-archive.ll

Loading...
View Options

lld/test/MachO/objc.s

Loading...