This is an archive of the discontinued LLVM Phabricator instance.

Differential D108776

[CMake] Add `--gdb-index` option to linker if split dwarf compiling
ClosedPublic

Authored by anton-afanasyev on Aug 26 2021, 11:42 AM.

Details

Reviewers
dblaikie
beanz
Commits
rGb1b68b4c0190: [CMake] Add `--gdb-index` option to linker if split dwarf compiling
Summary

The option --gdb-index should be passed to linker if compiler is invoked
with -gsplit-dwarf option. This allows debugger to locate the appropriate
units quickly. See "Invocation" section here: https://gcc.gnu.org/wiki/DebugFission

Suggested by @dblaikie here: https://reviews.llvm.org/D68556#1698442

Diff Detail

Revision Contents

PathSize
llvm/
cmake/
modules/
4 lines

Diff 369403

llvm/cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 895 Lines • ▼ Show 20 Lines
# Turn on -gsplit-dwarf if requested in debug builds. # Turn on -gsplit-dwarf if requested in debug builds.
if (LLVM_USE_SPLIT_DWARF AND if (LLVM_USE_SPLIT_DWARF AND
((uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG") OR ((uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG") OR
(uppercase_CMAKE_BUILD_TYPE STREQUAL "RELWITHDEBINFO"))) (uppercase_CMAKE_BUILD_TYPE STREQUAL "RELWITHDEBINFO")))
# Limit to clang and gcc so far. Add compilers supporting this option. # Limit to clang and gcc so far. Add compilers supporting this option.
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR if (CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR
CMAKE_CXX_COMPILER_ID STREQUAL "GNU") CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
add_compile_options(-gsplit-dwarf) add_compile_options(-gsplit-dwarf)
include(LLVMCheckLinkerFlag)
llvm_check_linker_flag(CXX "-Wl,--gdb-index" LINKER_SUPPORTS_GDB_INDEX)
append_if(LINKER_SUPPORTS_GDB_INDEX "-Wl,--gdb-index"
CMAKE_EXE_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
endif() endif()
endif() endif()
add_definitions( -D__STDC_CONSTANT_MACROS ) add_definitions( -D__STDC_CONSTANT_MACROS )
add_definitions( -D__STDC_FORMAT_MACROS ) add_definitions( -D__STDC_FORMAT_MACROS )
add_definitions( -D__STDC_LIMIT_MACROS ) add_definitions( -D__STDC_LIMIT_MACROS )
# clang and gcc don't default-print colored diagnostics when invoked from Ninja. # clang and gcc don't default-print colored diagnostics when invoked from Ninja.
▲ Show 20 Lines • Show All 321 Lines • Show Last 20 Lines