This is an archive of the discontinued LLVM Phabricator instance.

[sanitizers] Fix FreeBSD compilation after d568e5325c744dadf08729aee0819a8954a955f5

Authored by arichardson on Aug 26 2021, 3:19 AM.



FreeBSD doesn't use sanitizer_platform_limits_posix.h, so we get an
undefined reference to wordexp_wrde_dooffs error.
For some reason this currently triggers
warning: unused variable 'wordexp_wrde_dooffs' [-Wunused-const-variable]
while building sanitizer_platform_limits_freebsd.cpp despite the extern

Diff Detail

Event Timeline

arichardson created this revision.Aug 26 2021, 3:19 AM
arichardson requested review of this revision.Aug 26 2021, 3:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2021, 3:19 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
justincady accepted this revision.Aug 26 2021, 6:03 AM

Thanks for fixing this. When I saw <wordexp.h> conditionally included for everything except Android, I mistakenly assumed Android was the only platform that needed to be handled differently.


This revision is now accepted and ready to land.Aug 26 2021, 6:03 AM