This is an archive of the discontinued LLVM Phabricator instance.

do not merge, just a demo
AbandonedPublic

Authored by kuhnel on Aug 25 2021, 6:45 AM.

Details

Reviewers
agerbes

Diff Detail

Event Timeline

kuhnel requested review of this revision.Aug 25 2021, 6:45 AM
kuhnel created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2021, 6:45 AM
kuhnel abandoned this revision.Aug 25 2021, 6:59 AM

was just a demo

At least when making a review from arc, there's a way to make it private so it doesn't cause noise on the mailing list - I think @MaskRay has the right incantation to do that if it's useful to you.

MaskRay added a comment.EditedAug 30 2021, 10:15 PM

arc diff --draft 'HEAD^' does not send a Diff to llvm-commits, so that folks who subscribe to llvm-commits will not be upset :)

xgupta added a subscriber: xgupta.Aug 30 2021, 10:59 PM

arc diff --draft 'HEAD^' does not send a Diff to llvm-commits, so that folks who subscribe to llvm-commits will not be upset :)

I mention this on doc - https://reviews.llvm.org/D108970

arc diff --draft 'HEAD^' does not send a Diff to llvm-commits, so that folks who subscribe to llvm-commits will not be upset :)

I mention this on doc - https://reviews.llvm.org/D108970

Thanks! I'll try to remember it's there raather than pestering @MaskRay every time.

Thx for pointing that out! I was not aware of such a feature.