This is an archive of the discontinued LLVM Phabricator instance.

[clang] Move the soname declaration in a variable at the top of the file
ClosedPublic

Authored by sylvestre.ledru on Aug 23 2021, 12:57 AM.

Details

Summary

Currently, it is a bit buried in the file even if this is
pretty important for distro.

Diff Detail

Event Timeline

sylvestre.ledru requested review of this revision.Aug 23 2021, 12:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2021, 12:57 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay added inline comments.Aug 23 2021, 9:09 AM
clang/tools/libclang/CMakeLists.txt
176

The comment should be lifted as well.

Move the comment too

MaskRay accepted this revision.Aug 26 2021, 7:22 PM

Looks great!

This revision is now accepted and ready to land.Aug 26 2021, 7:22 PM