This is an archive of the discontinued LLVM Phabricator instance.

Differential D108465

[msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c
ClosedPublic

Authored by glider on Aug 20 2021, 6:53 AM.

Details

Reviewers
eugenis
melver
Commits
rG417a49e78e73: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c
Summary

Because KMSAN is not supported on many architectures, explicitly build
the test with -target x86_64-linux-gnu.

Diff Detail

Event Timeline

glider created this revision.Aug 20 2021, 6:53 AM
Herald added a subscriber: pengfei. · View Herald TranscriptAug 20 2021, 6:53 AM
glider requested review of this revision.Aug 20 2021, 6:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2021, 6:53 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
glider added a comment.Aug 20 2021, 6:54 AM

TBR

melver accepted this revision.Aug 20 2021, 6:55 AM

Who reported the issue? Might be worth mentioning in commit message, otherwise it appears to come out of nowhere (although it's semi-obvious given x86-64 is only supported).

This revision is now accepted and ready to land.Aug 20 2021, 6:55 AM
glider updated this revision to Diff 367783.Aug 20 2021, 6:58 AM

Updated patch description with links to bot failures.

glider added a comment.Aug 20 2021, 6:59 AM
In D108465#2957355, @melver wrote:

Who reported the issue? Might be worth mentioning in commit message, otherwise it appears to come out of nowhere (although it's semi-obvious given x86-64 is only supported).

Right. Added the links to the bot failures.

This revision was landed with ongoing or failed builds.Aug 20 2021, 7:00 AM
Closed by commit rG417a49e78e73: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c (authored by glider). · Explain Why
This revision was automatically updated to reflect the committed changes.
glider added a commit: rG417a49e78e73: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c.
Harbormaster completed remote builds in B120549: Diff 367783.Aug 20 2021, 7:50 AM

Revision Contents

PathSize
clang/
test/
CodeGen/
6 lines

Diff 367785

clang/test/CodeGen/sanitize-memory-disable.c

// RUN: %clang_cc1 -emit-llvm -o - %s | FileCheck -check-prefixes CHECK,WITHOUT %s // RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - %s | FileCheck -check-prefixes CHECK,WITHOUT %s
// RUN: %clang_cc1 -emit-llvm -o - %s -fsanitize=memory | FileCheck -check-prefixes CHECK,MSAN %s // RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - %s -fsanitize=memory | FileCheck -check-prefixes CHECK,MSAN %s
// RUN: %clang_cc1 -emit-llvm -o - %s -fsanitize=kernel-memory | FileCheck -check-prefixes CHECK,KMSAN %s // RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - %s -fsanitize=kernel-memory | FileCheck -check-prefixes CHECK,KMSAN %s
// Instrumented function. // Instrumented function.
// MSan uses memset(addr, -1, size) to poison allocas and stores shadow of the return value in // MSan uses memset(addr, -1, size) to poison allocas and stores shadow of the return value in
// __msan_retval_tls. KMSAN uses __msan_poison_alloca() to poison allocas and calls // __msan_retval_tls. KMSAN uses __msan_poison_alloca() to poison allocas and calls
// __msan_get_context_state() at function prologue to access the task context struct (including the // __msan_get_context_state() at function prologue to access the task context struct (including the
// shadow of the return value). // shadow of the return value).
// //
// CHECK-LABEL: i32 @instrumented1 // CHECK-LABEL: i32 @instrumented1
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines