[lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared libs

[pirama]

Summary

Add missing test coverage uncovered in review of D108006.

[MaskRay]

lld/test/ELF/undef-in-shared-from-lazy.s

2 ↗

(On Diff #367319)

# REQUIRES: x86
## Regular comments.
# RUN:
# CHECK: ...

3 ↗

(On Diff #367319)

Consider rm -fr %t && split-file %s %t

4 ↗

(On Diff #367319)

21 ↗

(On Diff #367319)

Use _start instead of main, then you can omit --entry

[MaskRay]

Worth checking whether archive-fetch.s can be folded into the test.

[pirama]

Update with review comments.

[pirama]

In D108328#2957896, @MaskRay wrote:

Worth checking whether archive-fetch.s can be folded into the test.

The test was added independent of the code change. Can you point me to the relevant code in InputFiles.cpp? Is it https://github.com/llvm/llvm-project/blob/9b9e7f6f4e05baa99a795e0cce60ba86091acc9a/lld/ELF/InputFiles.cpp#L1804?

[MaskRay]

Looks like archive-fetch.s is unrelated. LG.

I do encourage that contributors try making tests a bit more orthogonal and reorganize tests whenever that makes sense.

undef-in-shared-from-lazy.s => how about dso-undef-extract-lazy?

lld/test/ELF/undef-in-shared-from-lazy.s

35 ↗

(On Diff #368946)

Use .s suffix

39 ↗

(On Diff #368946)

Use .s suffix

[pirama]

• rename file
• append '.s' to split-file output names

[pirama]

lld/test/ELF/undef-in-shared-from-lazy.s

35 ↗

(On Diff #368946)

Added for main above as well.

lld/test/ELF/dso-undef-extract-lazy.s

+# REQUIRES: x86
+# RUN: rm -fr %t && split-file %s %t
+
+## Build an object with a trivial main function
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/main.s -o %t1.o
+
+## Build %t.a which defines a global 'foo'
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/archive.s -o %t2.o
+# RUN: rm -f %t2.a
+# RUN: llvm-ar rc %t2.a %t2.o
+
+## Build %t.so that has a reference to 'foo'
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/shlib.s -o %t3.o
+# RUN: ld.lld %t3.o -o %t3.so -shared
+
+## Test that 'foo' from %t2.a is fetched to define 'foo' needed by %t3.so.
+## Test both cases where the archive is before or after the shared library in
+## link order.
+
+# RUN: ld.lld %t1.o %t2.a %t3.so -o %t.exe
+# RUN: llvm-readelf --dyn-symbols %t.exe | FileCheck %s --check-prefix=CHECK-FETCH
+
+# RUN: ld.lld %t1.o %t3.so %t2.a -o %t.exe
+# RUN: llvm-readelf --dyn-symbols %t.exe | FileCheck %s --check-prefix=CHECK-FETCH
+
+# CHECK-FETCH: GLOBAL DEFAULT {{[0-9]+}} foo
+
+#--- main.s
+.text
+.globl _start
+.type _start,@function
+_start:
+  ret
+
+#--- archive.s
+.global foo
+foo:
+
+#--- shlib.s
+.global foo