This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] [Python] Fix out-of-tree Windows python bindings
ClosedPublic

Authored by jdd on Aug 16 2021, 7:16 PM.

Details

Summary

MSVC needs to know where to put the archive (.lib) as well as the runtime
(.dll). If left to the default location, multiple rules to generate the same
file will be produced, creating a Ninja error.

Diff Detail

Event Timeline

jdd created this revision.Aug 16 2021, 7:16 PM
jdd requested review of this revision.Aug 16 2021, 7:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2021, 7:20 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
jdd added a comment.Aug 16 2021, 7:20 PM

Landing this without review as it is "obvious".

Lgtm - thanks for the fix, as discussed.